Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scipy.integrate.trapezoid and scipy.integrate.simpson #87

Closed
wants to merge 1 commit into from

Conversation

rrjbca
Copy link

@rrjbca rrjbca commented Jun 2, 2024

In scipy 1.14 scipy.integrate.trapz and scipy.integrate.simps will be deprecated, see the Release Notes. Use the aliases scipy.integrate.trapezoid and scipy.integrate.simpson instead.

@sbailey
Copy link
Collaborator

sbailey commented Jun 10, 2024

Thanks for this update. Tests are failing because "scipy.integrate.trapezoid" didn't yet exist in scipy 1.5.4, which we currently still support. scipy 1.8.1, which we use at NERSC for our current environment, includes both trapz and trapezoid, and it looks like current speclite with trapz will start breaking with scipy 1.14 (not yet released) which removes trapz.

scipy 1.5.4 was released in Nov 2020. Does anyone have a compelling reason for why we should continue to support that, vs. drop support for that and update the tests to use the oldest version of scipy that includes scipy.integrate.trapezoid?

@rrjbca
Copy link
Author

rrjbca commented Jun 29, 2024

@sbailey is there any update on dropping support for scipy 1.5? If not I am happy to update this pull request to maintain compatibility with both trapz/simps and trapezoid/simpson. We have a downstream project waiting on speclite to adopt scipy 1.14 so are keen to see such a release as soon as possible.

@weaverba137
Copy link
Member

Thank you for pointing out this issue @rrjbca. This PR is now superseded by #91.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants