Circumvent warnings when running with Python >3.12 #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nan; this is the desired behavior, so just make it more explicit
…ng is never triggered
sbailey
reviewed
Dec 19, 2025
Contributor
Author
|
Looks like my fix broke another unit test, so I'll have to take a look at that, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues #865 and #866.
In both cases, the warnings that were being raised by the unit tests for Python 3.12 and 3.13 were benign.
For issue bool vs. int usage and bitwise inversion of photsys_north #865 we were already converting single Booleans using
notand Boolean arrays using~. I just had to restructure this conversion to place the~case in anif/elseblock.For issue cuts.py masked elements as NaN #866 the conversion of a single-element masked array to
NaNwas expected. I just had to make this conversion more explicit to prevent a warning being triggered.