Support for new laravel-mongodb version #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing version `jenseggers/laravel-mongodb = 3.5.*` to patch critical problem of pull 1712 [https://github.com/jenssegers/laravel-mongodb/pull/1712][Critical issue resolved]
This reverts commit 518435e. Accidental naming of package to self name.
|
Looks good to me, thanks. This change will support extra versions of jenssegers/mongodb but it won't require anyone to update so I don't think this alone needs to be considered a breaking change. |
|
@willtj current passport version is 7.2.1 maybe add that version too? I have tested and looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing version
jenseggers/laravel-mongodb = 3.5.*to patch critical problem [mongodb/laravel-mongodb/pull/1712]It will be a breaking change as it is specific to
laravel = "5.8"and will not work for anylaravel = "<5.8"Hence recommended to release new version with this change applied specifically for
laravel = "5.8".