Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call changed before variable update. #6

Merged
merged 1 commit into from
Apr 11, 2014
Merged

Call changed before variable update. #6

merged 1 commit into from
Apr 11, 2014

Conversation

pzagor2
Copy link

@pzagor2 pzagor2 commented Apr 2, 2014

@borderBite
Copy link
Collaborator

Thanks for the submission.

From the docs, it appears that changed() changes the state of the object.
Because of this, I don't think it matters if changed() is called before or after an attributes value is changed. However, your commit would make our code more consistent with the example in the ruby docs, so I'll merge it.
Thanks again.

borderBite pushed a commit that referenced this pull request Apr 11, 2014
@lottlizard
Merge pull request #6 from pzagor2/patch-1
fb1beb6 
Call changed before variable update.
@borderBite borderBite merged commit fb1beb6 into design-patterns-in-ruby:master Apr 11, 2014
@design-patterns-in-ruby design-patterns-in-ruby locked as resolved and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pzagor2 @borderBite