Update the pypa/gh-action-pypi-publish action version #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peytondmurray
force-pushed
the
ci-update-publish-action-version
branch
2 times, most recently
from
9189413
to
6e997dc
Compare
peytondmurray
force-pushed
the
ci-update-publish-action-version
branch
2 times, most recently
from
b3f292c
to
7ed9d25
Compare
|
Just reverted the change that pointed to test.pypi.org, so this should be good to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
pypa/gh-action-pypi-publishversion. After checking the requirements for this action, it looks like this usespkginfo==1.10.0, potentially solving the issue we're seeing.It's also been a while since a version was released, and trusted publishing now requires different permissions for the publish job. See https://github.com/pypa/gh-action-pypi-publish?tab=readme-ov-file#trusted-publishing for more information on this configuration; without it, I tried testing publishing releases to test.pypi.org and they failed.
@mlucool I don't have the permissions needed to edit trusted publishers on the PYPI project page, but it should be pretty easy to do so by following these instructions before attempting to make a new release: https://docs.pypi.org/trusted-publishers/adding-a-publisher/.
Alternatively if you'd prefer that I take care of it, add me to the project and I can do the trusted publishing setup.
A side effect of this PR is that we can now get rid of the PYPI_API_TOKEN secret.