Option to use speech-optimized tempo effect in from time_stretch()#89
Open
babua wants to merge 2 commits intodescriptinc:ps/pinwavesurferfrom
Open
Option to use speech-optimized tempo effect in from time_stretch()#89babua wants to merge 2 commits intodescriptinc:ps/pinwavesurferfrom
babua wants to merge 2 commits intodescriptinc:ps/pinwavesurferfrom
Conversation
…tch(), and set to True as default
Contributor
|
Looks like a good change. Do you mind editing the base branch of this PR to point to the one in this PR: #90, so I can merge it in with the next version, and updating the relevant test to cover the change? The test is here: https://github.com/descriptinc/audiotools/blob/master/tests/core/test_effects.py#L170-L181 |
Author
|
btw, it's been a while but in case it escaped your attention, I'd added the requested changes. if not, no need to reply! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SoX
tempoeffect has additional flags-sand-mwhich optimize WSOLA parameters for speech and music, respectively.In my testing, I found that using the
time_stretch()without the-sflag, there are significant artifacts in the audio, already at 0.7 or 1.3 factors, which are not too extreme, in my opinion. Simply adding the-sflag makes the output much more smoother.As AudioTools is speech-oriented, I think it would be a sane default for many users to use this flag in
time_stretch().Sample below with original, before, after, code was:
0.5_0.7_stretch_samples.zip