Skip to content

Conversation

@ruvenzx
Copy link
Contributor

@ruvenzx ruvenzx commented Nov 4, 2025

Related Issues

Fixes https://github.com/descope/etc/issues/12385

  • Tests
  • Documentation (if applicable)

@ruvenzx ruvenzx self-assigned this Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Coverage report

The coverage rate went from 98.21% to 98.22% ⬆️

100% of new lines are covered.

Diff Coverage details (click to unfold)

descope/management/common.py

100% of new lines are covered (99.59% of the complete file).

descope/management/tenant.py

100% of new lines are covered (100% of the complete file).

@ruvenzx
Copy link
Contributor Author

ruvenzx commented Nov 4, 2025

coverage % went down @guyp-descope please advise

@dorsha
Copy link
Member

dorsha commented Nov 5, 2025

coverage % went down @guyp-descope please advise

@ruvenzx you can see the lines that are not covered by tests, just add missing tests:

image

@ruvenzx ruvenzx marked this pull request as ready for review November 5, 2025 08:19
Copilot AI review requested due to automatic review settings November 5, 2025 08:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds tenant session settings management functionality to the Descope SDK, enabling users to configure and retrieve session-related settings for tenants including token expiration times, inactivity settings, and authentication types.

  • Adds update_settings() and load_settings() methods to the Tenant class for managing tenant session configurations
  • Introduces new enums SessionExiprationUnit and TenantAuthType to support session settings parameters
  • Includes comprehensive test coverage for both new methods

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
descope/management/tenant.py Implements update_settings() and load_settings() methods for tenant session settings management
descope/management/common.py Adds SessionExiprationUnit and TenantAuthType enums and tenant_settings_path constant
tests/management/test_tenant.py Adds test cases for update_settings() and load_settings() methods
README.md Documents the new tenant settings management functions with usage examples

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ruvenzx and others added 3 commits November 5, 2025 14:22
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ruvenzx ruvenzx merged commit 9c145b6 into main Nov 5, 2025
24 checks passed
@ruvenzx ruvenzx deleted the tenant-session-settings-functions branch November 5, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants