-
Notifications
You must be signed in to change notification settings - Fork 9
tenant session settings functions #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)descope/management/common.py
descope/management/tenant.py
|
|
coverage % went down @guyp-descope please advise |
@ruvenzx you can see the lines that are not covered by tests, just add missing tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds tenant session settings management functionality to the Descope SDK, enabling users to configure and retrieve session-related settings for tenants including token expiration times, inactivity settings, and authentication types.
- Adds
update_settings()andload_settings()methods to the Tenant class for managing tenant session configurations - Introduces new enums
SessionExiprationUnitandTenantAuthTypeto support session settings parameters - Includes comprehensive test coverage for both new methods
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| descope/management/tenant.py | Implements update_settings() and load_settings() methods for tenant session settings management |
| descope/management/common.py | Adds SessionExiprationUnit and TenantAuthType enums and tenant_settings_path constant |
| tests/management/test_tenant.py | Adds test cases for update_settings() and load_settings() methods |
| README.md | Documents the new tenant settings management functions with usage examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Related Issues
Fixes https://github.com/descope/etc/issues/12385