fix the jet response object returned during validate_session_request #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asafshen
previously approved these changes
Oct 11, 2022
Member
asafshen
left a comment
asafshen
left a comment
There was a problem hiding this comment.
looks good 👍
added some minor comments
also, making sure this is aligned (or soon to be aligneD) with other sdks logic, right?
Contributor
Author
Its not relevant for other sdk |
Member
our of curiosity - why? |
Contributor
Author
|
Because in other languages we have a different structs and the data organized in different way as you may know. |
…so it will now include the adjusted permissions,roles,projectID,userID fields (so it will be just the same as returned from verify_code)
omercnet
force-pushed
the
fix-jwt-response-object-on-validate-request
branch
from
6d16079 to
9cceb1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the jet response object returned during validate_session_request so it will now include the adjusted permissions,roles,projectID,userID fields (so it will be just the same as returned from verify_code)