-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: AdminWidget Enable/Disable/RemovePasskey and editable support #409
Conversation
…js into enableDisableUserWidget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Added some comments
...ent-widget/src/lib/widget/mixins/initMixin/initComponentsMixins/initDisableUserModalMixin.ts
Outdated
Show resolved
Hide resolved
...-widget/src/lib/widget/mixins/initMixin/initComponentsMixins/initRemovePasskeyButtonMixin.ts
Outdated
Show resolved
Hide resolved
...nt-widget/src/lib/widget/mixins/initMixin/initComponentsMixins/initDisableUserButtonMixin.ts
Outdated
Show resolved
Hide resolved
...-widget/src/lib/widget/mixins/initMixin/initComponentsMixins/initRemovePasskeyButtonMixin.ts
Outdated
Show resolved
Hide resolved
packages/user-management-widget/src/lib/widget/mixins/initMixin/initMixin.ts
Show resolved
Hide resolved
packages/user-management-widget/src/lib/widget/state/selectors.ts
Outdated
Show resolved
Hide resolved
…n/initComponentsMixins/initDisableUserModalMixin.ts Co-authored-by: nirgur <nirgur@users.noreply.github.com> Signed-off-by: Tomer Lichtash <tomer@descope.com>
…n/initComponentsMixins/initRemovePasskeyButtonMixin.ts Co-authored-by: nirgur <nirgur@users.noreply.github.com> Signed-off-by: Tomer Lichtash <tomer@descope.com>
Co-authored-by: nirgur <nirgur@users.noreply.github.com> Signed-off-by: Tomer Lichtash <tomer@descope.com>
Added support for custom attributes in edit user modal. FYI @aviadl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
I think we should make it a bit more generic
LMKWYT
...gement-widget/src/lib/widget/mixins/initMixin/initComponentsMixins/initEditUserModalMixin.ts
Outdated
Show resolved
Hide resolved
...gement-widget/src/lib/widget/mixins/initMixin/initComponentsMixins/initEditUserModalMixin.ts
Outdated
Show resolved
Hide resolved
…js into enableDisableUserWidget
Related Issues
Related screens https://github.com/descope/content/pull/417
Related PRs
Description
A few sentences describing the overall goals of the pull request's commits.
Must