Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AdminWidget Enable/Disable/RemovePasskey and editable support #409

Merged
merged 29 commits into from
Mar 12, 2024

Conversation

tomerlichtash
Copy link
Member

@tomerlichtash tomerlichtash commented Mar 5, 2024

Related Issues

Related screens https://github.com/descope/content/pull/417

Related PRs

branch PR
service a PR Link to PR
service b PR Link to PR

Description

A few sentences describing the overall goals of the pull request's commits.

Must

  • Tests
  • Documentation (if applicable)

@tomerlichtash tomerlichtash enabled auto-merge (squash) March 10, 2024 16:23
Copy link
Collaborator

@nirgur nirgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Added some comments

tomerlichtash and others added 4 commits March 11, 2024 01:25
…n/initComponentsMixins/initDisableUserModalMixin.ts

Co-authored-by: nirgur <nirgur@users.noreply.github.com>
Signed-off-by: Tomer Lichtash <tomer@descope.com>
…n/initComponentsMixins/initRemovePasskeyButtonMixin.ts

Co-authored-by: nirgur <nirgur@users.noreply.github.com>
Signed-off-by: Tomer Lichtash <tomer@descope.com>
Co-authored-by: nirgur <nirgur@users.noreply.github.com>
Signed-off-by: Tomer Lichtash <tomer@descope.com>
@tomerlichtash
Copy link
Member Author

Added support for custom attributes in edit user modal. FYI @aviadl

Copy link
Collaborator

@nirgur nirgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
I think we should make it a bit more generic

LMKWYT

@tomerlichtash tomerlichtash changed the title feat: AdminWidget Enable/Disable user feat: AdminWidget Enable/Disable/RemovePasskey and editable support Mar 12, 2024
@tomerlichtash tomerlichtash merged commit 6a27740 into main Mar 12, 2024
5 checks passed
@tomerlichtash tomerlichtash deleted the enableDisableUserWidget branch March 12, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants