fix(types): make admin classes generic as their super classes #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good start, now let's fix CI :) |
|
You might be interested in this thread: lazybird/django-solo#128 (comment), where I proposed a (verbose) solution. |
mschoettle
changed the title
mschoettle
force-pushed
the
add-generic-type
branch
from
3dc21ad
to
bb60052
Compare
|
Merged it! Thanks for your contribution! |
|
Thanks a lot for fixing the last issues and merging it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseModelAdminandModelAdminare generic:https://github.com/typeddjango/django-stubs/blob/496190e1b5dc344980d8f6ee81ff5dcecc05ded9/django-stubs/contrib/admin/options.pyi#L88
https://github.com/typeddjango/django-stubs/blob/496190e1b5dc344980d8f6ee81ff5dcecc05ded9/django-stubs/contrib/admin/options.pyi#L145
This PR makes the translation admin classes generic as well.