Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce LEGENDARY_CONFIG_PATH #590

Merged
merged 2 commits into from
Oct 14, 2023
Merged

Conversation

Etaash-mathamsetty
Copy link
Contributor

@Etaash-mathamsetty Etaash-mathamsetty commented Aug 11, 2023

This allows heroic games launcher to use a custom directory for its config while not messing with the config paths of other wrapper scripts which also read XDG_CONFIG_HOME

I don't write python code and defintely don't exactly know what a := operator does, so pls correct this if it's wrong

@derrod
Copy link
Owner

derrod commented Sep 9, 2023

Wouldn't it make more sense to not have a subdirectory if you're specifying the config path directly?

@Etaash-mathamsetty
Copy link
Contributor Author

Etaash-mathamsetty commented Sep 9, 2023

Wouldn't it make more sense to not have a subdirectory if you're specifying the config path directly?

Agreed, but this is supposed to be a drop in replacement for XDG_CONFIG_HOME, to make it easier for the user

@Etaash-mathamsetty
Copy link
Contributor Author

@derrod I no longer append legendary to the path, is it good now?

@derrod derrod merged commit c56a81a into derrod:master Oct 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants