Develop

[Benawi]

Implemented Features

General requirements

• Make sure that there are no linter errors.
• Make sure that you used the correct Gitflow.
• Make sure that you documented your work in a professional way.

Ruby requirements

• Follow our list of best practices for Ruby.

Project requirements

• All methods visible in the diagram should be implemented
• All properties visible in the diagram should be defined and set up in the constructor method.
• User interface : console app entry-point is created
• Set up associations between classes and objects.
• All data should be preserved by saving collections in .json files.
• Build interactive console apps
• Create a schema.sql file with tables that will be analogical to the structure of the classes in your app

[danmainah]

Hi @Benawi , @kayjeee and @derrick1451 ,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

✔️ Ensured all the options in the UI are working correctly
✔️ Ensured data is stored correctly after the user exits the app.
✔️ All the tests added are passing.

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[Benawi]

Changes ♻

• A new video recorded 👁 Walkthrough
• A procedure on how to run the project locally after cloning and installing dependencies added in the readme file
• A condition in item class which checks if published_date is older than or equal to 10 years is updated
• Test cases added tests for these methods: to_s,to_json, and self.from_json in the following test files
  • spec/book_spec.rb
  • spec/author_spec.rb
  • spec/genre_spec.rb
  • spec/album_spec.rb
  • spec/game_spec.rb
• A references for the game_id and author_id is added in sql/schema.sql file
• Indexes for all the foreign keys added in sql/schema.sql file

[OyePriscilla]

Hi @Benawi, @kayjeee and @derrick1451 👏 👏 👏 👏,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Engaging presentation within time frame ✔️
Implemented tests for to.s and to_json methods ✔️

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[Benawi]

Changes ♻

• All the repeated tables (Items) removed from sql/schema.sql

[KanzaTahreem]

Approved 🙌

Hi @team

Good job implementing the suggested changes 💪 Your project is COMPLETE! There is nothing else to say other than... it's time to merge it! 🚀 Congratulations!

Highlights 🎯

There are some excellent points that you have made perfectly. Keep up the great work! 👏

• ✅ Repeated tables are removed
• ✅ Your README looks good
• ✅ Linters are working properly

Optional suggestions ❕

N/A

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👨‍💻💻

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.