Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
libsocketConfig.cmake.in
assumes that the library target is calledsocket++
, but the static library is currently calledsocket++_int
. Thus, using the static build of libsocket with FetchContent is currently broken.This commit changes the static library target name to the same as the shared library. The drawback is that now
BUILD_SHARED_LIBS
andBUILD_STATIC_LIBS
cannot be enabled both at the same time, because it would lead to a name collision.