Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Send image data in chunks (ellensp's fix) #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

miramiram
Copy link
Contributor

Fix by @ellensp - derkalle4/python3-idotmatrix-client#50 (comment)
It's been many months so I assume they've forgotten to open a PR for it

Fix by ellensp: derkalle4/python3-idotmatrix-client#50 (comment)
Its been many months so I assume they've forgotten to open a PR for it
@ellensp
Copy link
Contributor

ellensp commented Mar 22, 2025

no, someone said it didn't work on 64x64 and since I only have access to the 32x32 I could not test, confirm or investigate further

@miramiram
Copy link
Contributor Author

Oh I see, I don't have one so that's difficult
Though I can't find anyone saying that in the linked thread, did they give any more info?
The person saying they could upload 64x64 gifs but not images didn't mention using the patch

@miramiram
Copy link
Contributor Author

Also if you wanna open a PR for this yourself so it gets properly attributed I can close this one. There oughta be a PR for it open so there's a place to collaborate on it properly, even if it needs improvements

@ellensp
Copy link
Contributor

ellensp commented Mar 22, 2025

I'm good. If you click on my github user name you will find I have some 200 contributions to opensource projects in the last year... I don't' "need" another one :)

@silvioBi
Copy link

Hello there, I got a 64x64 screen and for me images are not working and gifs are working only if not above 4KB.
If you tell me how I will be happy to test this out ✌🏼

@ellensp
Copy link
Contributor

ellensp commented May 15, 2025

@silvioBi
In the above patch data is sent in 512 byte chunks. I suspect the 64x64 doesn't have that much free ram.
Use this patch and try smaller values instead of the 512 in this line

chunks = self._splitIntoChunks(data, 512)

ie try these in turn 256, 128, 64, 32

@miramiram
Copy link
Contributor Author

Also you might have to give it the "reset" command every now and again when working with files of this size, it seems to reset ram & flash and clear up issues. It's in the client but I can't recall if I added it in the library too, lmk if you don't find it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants