Skip to content

Conversation

@derjust
Copy link
Owner

@derjust derjust commented Nov 28, 2018

This PR merges all code & all changes from all parties to give credit to everyone!

@codecov-io
Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #223 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #223      +/-   ##
===========================================
+ Coverage     65.21%   65.4%   +0.19%     
- Complexity      598     600       +2     
===========================================
  Files            77      77              
  Lines          2038    2038              
  Branches        374     374              
===========================================
+ Hits           1329    1333       +4     
+ Misses          554     550       -4     
  Partials        155     155
Impacted Files Coverage Δ Complexity Δ
.../repository/support/DynamoDBRepositoryFactory.java 85.1% <ø> (ø) 20 <0> (ø) ⬇️
.../data/dynamodb/mapping/DynamoDBMappingContext.java 75% <0%> (+25%) 8% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9356e42...82285cf. Read the comment docs.

@derjust derjust merged commit 03c017d into master Nov 28, 2018
@boostchicken
Copy link

Just a note, you dont need that block of code in PartTreeDynamoDBQueryUnitTest.java

It will increase coverage as well.

@derjust
Copy link
Owner Author

derjust commented Nov 30, 2018

@boostchicken I'm sorry I'm not following.
Which lines are you referring to that should be removed in PartTreeDynamoDBQueryUnitTest.java?
I'm afraid now that the merge missed something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants