Prince/ added shiftai workflows #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency ReviewThe following issues were found:
License Issues.github/workflows/ai-code-analysis.yml
OpenSSF Scorecard
Scanned Manifest Files.github/workflows/ai-code-analysis.yml
.github/workflows/ai-dashboard.yml |
- Move permissions from global to job level for both workflows - Replace direct GitHub context usage with environment variables - Prevent script injection attacks in GitHub Actions scripts - Follow GitHub security best practices for workflow design REF: GitHub security recommendations for workflow permissions and injection prevention
amam-deriv
reviewed
Aug 5, 2025
| run: | | ||
| cat > analyze_script.js << 'EOF' | ||
| const fs = require('fs'); | ||
| const path = require('path'); |
There was a problem hiding this comment.
why is this being injected rather than have a concrete debuggable file?
amam-deriv
reviewed
Aug 5, 2025
| // Get the diff for this specific file, showing only added lines | ||
| // Note: Using path.normalize() would require additional import, | ||
| // but git itself provides good protection against path traversal | ||
| const diffCommand = `git diff origin/${baseRef}...HEAD -- "${filePath}"`; |
There was a problem hiding this comment.
why are we diffing again here?, isn't previous step already giving us diff?
There was a problem hiding this comment.
First diff gets us the list of files that changed:
git diff --name-only "origin/$PR_BASE_REF...HEAD"This just gives us filenames like: app.js, utils.js, README.md
Second diff gets us the actual content that was added in each file:
git diff origin/${baseRef}...HEAD -- "${filePath}"This shows the real diff with + and - lines.
Why we need both:
Think of it like this - the first one answers "What files were touched?" and the second one answers "What was actually added to this specific file?"
We only want to analyze the newly added content (the + lines), not the entire file. So we need to:
- Know which files to look at (first diff)
- Extract just the added lines from each file (second diff)
- Search those added lines for
[AI]tags
Without the second diff, we'd just have filenames but no idea what content was actually added to scan for AI-generated code.
amam-deriv
reviewed
Aug 5, 2025
| const AI_BLOCK_REGEXES = [ | ||
| { | ||
| name: 'universal', | ||
| regex: /\[AI\]([\s\S]*?)\[\/AI\]/g, |
There was a problem hiding this comment.
i thought we uses a vectordb or a service for checking this, this looks like a loophole to me?
amam-deriv
reviewed
Aug 5, 2025
| if: steps.check-skip.outputs.should-skip == 'false' | ||
| run: | | ||
| # Create the dashboard generation script inline | ||
| cat << 'EOF' > generate-dashboard.js |
There was a problem hiding this comment.
same here, i think we can create a concrete js file for this
There was a problem hiding this comment.
It was previously a standalone JS file. After moving it into a reusable workflow, it's now being referenced from the caller’s repository instead of this one, which results in a "file not found" error.
There was a problem hiding this comment.
i see, can it referenced the file link instead, for e.g github.com/deriv-com/shared-actions/scripts/generate-dashboard.js
amam-deriv
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.