-
Notifications
You must be signed in to change notification settings - Fork 12
feat: add buildSemantics to base classes and vertical barrier painter #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add buildSemantics to base classes and vertical barrier painter #388
Conversation
Reviewer's GuideThis PR introduces accessibility semantics across the chart rendering pipeline by extending the ChartData and SeriesPainter interfaces, wiring a semanticsBuilder in ChartPainter and example app, and adding buildSemantics overrides to most painter classes. It also refactors VerticalBarrierPainter by extracting helper methods for animation, line placement, and labeling, and implements full semantics support for vertical barriers. Sequence Diagram for Chart Semantics GenerationsequenceDiagram
title Sequence Diagram for Chart Semantics Generation
participant Client as "Flutter Engine/SemanticsBinding"
participant ChartPainter_Instance as "ChartPainter"
participant Series_Instance as "Series (implements ChartData)"
participant SeriesPainter_Instance as "SeriesPainter (e.g. VerticalBarrierPainter)"
Client->>ChartPainter_Instance: Accesses semanticsBuilder property
ChartPainter_Instance->>Series_Instance: buildSemantics(size, epochToX, quoteToY)
Series_Instance->>SeriesPainter_Instance: buildSemantics(size, epochToX, quoteToY)
SeriesPainter_Instance-->>Series_Instance: Returns List~CustomPainterSemantics~
Series_Instance-->>ChartPainter_Instance: Returns List~CustomPainterSemantics~
ChartPainter_Instance-->>Client: Provides SemanticsBuilderCallback (which returns the List)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Clickup link: https://app.clickup.com/t/20696747/GRWT-6126
Fixes issue: #
This PR contains the following changes:
Developers Note (Optional)
Pre-launch Checklist (For PR creator)
As a creator of this PR:
Reviewers
Pre-launch Checklist (For Reviewers)
As a reviewer I ensure that:
Pre-launch Checklist (For QA)
Pre-launch Checklist (For Maintainer)
Summary by Sourcery
Add accessibility semantics support across chart components by defining buildSemantics methods on chart data and painters, integrating semanticsBuilder in ChartPainter, and initializing semantics in the example app.
New Features:
Enhancements: