Amir/FEQ-219/Upgrade node version to 18 #8877

amir-deriv · 2023-06-01T13:07:51Z

Changes:

Upgrade node js version from 16 to 18

Screenshots:

Please provide some screenshots of the change.

vercel · 2023-06-01T13:07:56Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 8, 2023 4:17am

codecov · 2023-06-01T13:37:13Z

Codecov Report

Merging #8877 (0655e76) into master (cb52143) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8877   +/-   ##
=======================================
  Coverage   19.98%   19.98%           
=======================================
  Files        1817     1817           
  Lines       41156    41156           
  Branches     8178     8178           
=======================================
  Hits         8227     8227           
  Misses      32085    32085           
  Partials      844      844

github-actions · 2023-06-02T02:50:55Z

A production App ID was automatically generated for this PR. (log)

PR: Amir/FEQ-219/Upgrade node version to 18 #8877
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-amir-deriv-amir-feq-219upgrade-nodejs-fccf7d.binary.sx?qa_server=red.binaryws.com&app_id=32181
- Original: https://deriv-app-git-fork-amir-deriv-amir-feq-219upgrade-nodejs-fccf7d.binary.sx
App ID: 32181

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8877](https://github.com/binary-com/deriv-app/pull/8877)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amir-deriv-amir-feq-219upgrade-nodejs-fccf7d.binary.sx?qa_server=red.binaryws.com&app_id=32181
    - **Original**: https://deriv-app-git-fork-amir-deriv-amir-feq-219upgrade-nodejs-fccf7d.binary.sx
- **App ID**: `32181`

github-actions · 2023-06-02T02:51:23Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	21
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-amir-deriv-amir-feq-219upgrade-nodejs-fccf7d.binary.sx/

ali-hosseini-deriv · 2023-06-02T07:29:48Z

hey @amir-deriv, you also need to update the node version in circleci config.

…m:amir-deriv/deriv-app into amir/feq-219/upgrade-nodejs-version-to-18

ali-hosseini-deriv · 2023-06-06T12:16:28Z

@amir-deriv please update the readme file too. we have a badge there.

…m:amir-deriv/deriv-app into amir/feq-219/upgrade-nodejs-version-to-18

shayan-deriv · 2023-06-07T04:13:36Z

packages/shared/src/utils/url/__tests__/url.js

+    Object.defineProperty(window, 'location', {
+        writable: true,
+        value: new URL(url),
+    });


just out of curiosity, didn't the previous code work with node 18? 🤔

+1, any reason for this change?

package.json

yashim-deriv · 2023-06-07T06:58:30Z

packages/account/package.json

@@ -11,7 +11,7 @@
        "url": "https://github.com/binary-com/deriv-app/issues"
    },
    "engines": {
-        "node": "^16.16.0"
+        "node": "^18.16.0"


same to old. using a more general 18.x is better imo

yashim-deriv · 2023-06-07T06:59:16Z

packages/shared/src/utils/url/__tests__/url.js

+    Object.defineProperty(window, 'location', {
+        writable: true,
+        value: new URL(url),
+    });


+1, any reason for this change?

Co-authored-by: yashim-deriv <yashim@regentmarkets.com>

amir-deriv · 2023-06-07T08:01:05Z

@yashim-deriv @shayan-deriv

This is related to node 18.x , it's not letting us redefine a property on window the way we were doing it before so I just changed the way to do it. It's working on node 19.x but the fix is not there in 18.x

please refer to this. nodejs/node#47563

…m:amir-deriv/deriv-app into amir/feq-219/upgrade-nodejs-version-to-18

sonarcloud · 2023-06-08T04:03:45Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
4.8% Duplication

github-actions · 2023-06-08T04:37:51Z

⏳ Generating Lighthouse report...

This reverts commit ed0eca0.

chore: upgrade to node 18

e0d16a2

amir-deriv requested a review from yashim-deriv as a code owner June 1, 2023 13:07

boring-cyborg bot added Account AppStore Bot Components Core P2P Shared Trader Translations labels Jun 1, 2023

vercel bot had a problem deploying to Preview June 1, 2023 13:19 Failure

Merge branch 'master' into amir/feq-219/upgrade-nodejs-version-to-18

4e08fe7

vercel bot deployed to Preview June 2, 2023 02:50 View deployment

Merge branch 'master' into amir/feq-219/upgrade-nodejs-version-to-18

6d62e3d

amir-deriv added 2 commits June 2, 2023 12:33

chore: update node version in circle ci config

94e54eb

Merge branch 'amir/feq-219/upgrade-nodejs-version-to-18' of github.co…

4b5296d

…m:amir-deriv/deriv-app into amir/feq-219/upgrade-nodejs-version-to-18

vercel bot had a problem deploying to Preview June 2, 2023 07:39 Failure

vercel bot deployed to Preview June 2, 2023 08:02 View deployment

Merge branch 'master' into amir/feq-219/upgrade-nodejs-version-to-18

4bfa96f

vercel bot deployed to Preview June 6, 2023 12:12 View deployment

amir-deriv added 2 commits June 6, 2023 17:20

chore: update node version in readme file

b79cd5c

Merge branch 'amir/feq-219/upgrade-nodejs-version-to-18' of github.co…

109688f

…m:amir-deriv/deriv-app into amir/feq-219/upgrade-nodejs-version-to-18

boring-cyborg bot added the Docs label Jun 6, 2023

vercel bot had a problem deploying to Preview June 6, 2023 12:37 Failure

hamid-deriv previously approved these changes Jun 7, 2023

View reviewed changes

shayan-deriv reviewed Jun 7, 2023

View reviewed changes

shayan-deriv previously approved these changes Jun 7, 2023

View reviewed changes

yashim-deriv reviewed Jun 7, 2023

View reviewed changes

update: node in engines prop

ee0378c

Co-authored-by: yashim-deriv <yashim@regentmarkets.com>

amir-deriv dismissed stale reviews from shayan-deriv and hamid-deriv via ee0378c June 7, 2023 07:58

amir-deriv added 2 commits June 7, 2023 13:02

chore: update node version to generic 18.x

d8b5682

Merge branch 'amir/feq-219/upgrade-nodejs-version-to-18' of github.co…

5440ec0

…m:amir-deriv/deriv-app into amir/feq-219/upgrade-nodejs-version-to-18

shayan-deriv previously approved these changes Jun 7, 2023

View reviewed changes

vercel bot deployed to Preview June 7, 2023 08:26 View deployment

chore: update node version to generic 18.x in readme badge

f26a84a

amir-deriv dismissed shayan-deriv’s stale review via f26a84a June 7, 2023 08:26

vercel bot had a problem deploying to Preview June 7, 2023 08:48 Failure

Merge branch 'master' into amir/feq-219/upgrade-nodejs-version-to-18

7579e9c

vercel bot deployed to Preview June 8, 2023 03:43 View deployment

Merge branch 'master' into amir/feq-219/upgrade-nodejs-version-to-18

0655e76

vercel bot deployed to Preview June 8, 2023 04:17 View deployment

ali-hosseini-deriv approved these changes Jun 8, 2023

View reviewed changes

ali-hosseini-deriv merged commit ed0eca0 into deriv-com:master Jun 8, 2023

ali-hosseini-deriv added a commit that referenced this pull request Jun 8, 2023

Revert "Amir/FEQ-219/Upgrade node version to 18 (#8877)"

e7ad810

This reverts commit ed0eca0.

ali-hosseini-deriv mentioned this pull request Jun 8, 2023

Revert "Amir/FEQ-219/Upgrade node version to 18" #8945

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Amir/FEQ-219/Upgrade node version to 18 #8877

Amir/FEQ-219/Upgrade node version to 18 #8877

amir-deriv commented Jun 1, 2023

vercel bot commented Jun 1, 2023 •

edited

Loading

codecov bot commented Jun 1, 2023 •

edited

Loading

github-actions bot commented Jun 2, 2023 •

edited

Loading

github-actions bot commented Jun 2, 2023 •

edited

Loading

ali-hosseini-deriv commented Jun 2, 2023

ali-hosseini-deriv commented Jun 6, 2023

shayan-deriv Jun 7, 2023

yashim-deriv Jun 7, 2023

yashim-deriv Jun 7, 2023

yashim-deriv Jun 7, 2023

amir-deriv commented Jun 7, 2023

sonarcloud bot commented Jun 8, 2023

github-actions bot commented Jun 8, 2023

Amir/FEQ-219/Upgrade node version to 18 #8877

Amir/FEQ-219/Upgrade node version to 18 #8877

Conversation

amir-deriv commented Jun 1, 2023

Changes:

Screenshots:

vercel bot commented Jun 1, 2023 • edited Loading

codecov bot commented Jun 1, 2023 • edited Loading

Codecov Report

github-actions bot commented Jun 2, 2023 • edited Loading

github-actions bot commented Jun 2, 2023 • edited Loading

ali-hosseini-deriv commented Jun 2, 2023

ali-hosseini-deriv commented Jun 6, 2023

shayan-deriv Jun 7, 2023

Choose a reason for hiding this comment

yashim-deriv Jun 7, 2023

Choose a reason for hiding this comment

yashim-deriv Jun 7, 2023

Choose a reason for hiding this comment

yashim-deriv Jun 7, 2023

Choose a reason for hiding this comment

amir-deriv commented Jun 7, 2023

sonarcloud bot commented Jun 8, 2023

github-actions bot commented Jun 8, 2023

vercel bot commented Jun 1, 2023 •

edited

Loading

codecov bot commented Jun 1, 2023 •

edited

Loading

github-actions bot commented Jun 2, 2023 •

edited

Loading

github-actions bot commented Jun 2, 2023 •

edited

Loading