Add support for Modulesync #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will look at the faulty acceptance tests tomorrow. |
… Systemd unit file
|
This is looking good so far, but I think we need to do some more refactoring. For example CDH 6 is not supported and CDH 4 is end of life. |
|
@deric I would appreciate it, if you would merge this pull request. |
|
It's quite a lot of changes, sorry I didn't have earlier time to check all. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-zookeeper
that referenced
this pull request
Sep 7, 2020
* Add support for Modulesync * Fix several lint issues * Fix several rubocop issues * Remove check for supported operating systems * Remove parameter port, because it has a default value * Remove parameter service_provider, because it is defined at params.pp * Add default for parameters repo and cdhver, since this only affects RedHat * Add parameter service_name * Add parameter install_java and java_package * Add parameter initialize_datastore * Readd support for init scripts, because RedHat / CentOS 6 does not use systemd * Add parameter service_provider, because Cloudera 5 does not provide a Systemd unit file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a variety of Rake tasks and TravisCI tests. You also might want to add the Travis CI secret to the file
.sync.yml. This allows you to automatically deploy a new release to the Puppetforge.For further information take a look at: