Update archive filename for version 3.5.5+ install #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update archive/tests * update filename logic * update zoo_path
manifests/install/archive.pp
Outdated
|
|
||
|
|
||
| # Apache updated the filename base for archive files in release 3.5.5 | ||
| if versioncmp($::zookeeper::archive_version, '3.5.5') <= 0 { |
There was a problem hiding this comment.
@andriisabitov Yes, I agree, the logic seems to be inversed. versioncmp(a, b) will return -1 if version a is less than version b. In this case for version 3.4.1 the new filename will be used.
deric
requested changes
Jun 10, 2019
manifests/install/archive.pp
Outdated
|
|
||
|
|
||
| # Apache updated the filename base for archive files in release 3.5.5 | ||
| if versioncmp($::zookeeper::archive_version, '3.5.5') <= 0 { |
There was a problem hiding this comment.
@andriisabitov Yes, I agree, the logic seems to be inversed. versioncmp(a, b) will return -1 if version a is less than version b. In this case for version 3.4.1 the new filename will be used.
|
@deric @andriisabitov good catch, my apologies. This commit somehow didn't make it into the initial PR commit from local testing. Should be good to go now 😄 |
|
No problem, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache updated the archive file name (apparently) starting with version 3.5.5 which was released last week. This effectively resolves the issue with a minor change, the
zoo_dirvariable is now pointed to the symlink location as opposed to the per-version directory. I found this to be the most direct way of fixing the issue whilst not refactoring a decent bit of code. I opened #129 regarding this issue and as promised, here's my proposed fix to the issue.update archive/tests
update filename logic
update zoo_path