Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails on empty $::domain #117

Closed
mszymo opened this issue Sep 18, 2018 · 3 comments
Closed

Fails on empty $::domain #117

mszymo opened this issue Sep 18, 2018 · 3 comments

Comments

@mszymo
Copy link

mszymo commented Sep 18, 2018

Ubuntu 16.04 LTS
Puppet version 5.5.6

If the server has no domain set up (meaning the trusted fact $::domain is empty) then the module fails on params.pp L 150. This is because $realm = $::domain, and cannot handle if it is empty. Changing it to $realm = 'local.domain' allows the module to run correctly. Seems to be only used for the Jaas stuff?

@rmalenko
Copy link

We are using full domain name in puppet agent configuration sow we can use
$trusted['certname']

@deric
Copy link
Owner

deric commented Jun 14, 2019

@rmalenko The value would be slightly different $::domain would return example.com whereas $trusted['certname'] would be something like web01.example.com. But as long as it is just default value that can be overwritten we should avoid errors like this.

@deric
Copy link
Owner

deric commented Jun 21, 2019

Resolved in v0.8.5

@deric deric closed this as completed Jun 21, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-zookeeper that referenced this issue Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants