fix: fixed AbstractSingleItemDbxFirebaseDocument setFirestoreCollection

- fixed issue where AbstractSingleItemDbxFirebaseDocument's setFirestoreCollection did not handle the Maybe input properly
dereekb · Jul 13, 2022 · d0e8352 · d0e8352
1 parent a72284f
commit d0e8352
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/packages/dbx-firebase/src/lib/model/store/store.subcollection.document.ts b/packages/dbx-firebase/src/lib/model/store/store.subcollection.document.ts
@@ -79,12 +79,16 @@ export class AbstractSingleItemDbxFirebaseDocument<T, PT, D extends FirestoreDoc
    * Sets the SingleItemFirestoreCollection to use.
    */
   override readonly setFirestoreCollection = this.updater((state, firestoreCollection: Maybe<FirestoreCollection<T, D>>) => {
-    const id = (firestoreCollection as SingleItemFirestoreCollection<T, PT, D, PD>).singleItemIdentifier;
-
-    if (id != null) {
-      return { ...state, firestoreCollection, id };
+    if (firestoreCollection != null) {
+      const id = (firestoreCollection as SingleItemFirestoreCollection<T, PT, D, PD>).singleItemIdentifier;
+
+      if (id != null) {
+        return { ...state, firestoreCollection, id };
+      } else {
+        throw new Error('AbstractSingleItemDbxFirebaseDocument only accepts SingleItemFirestoreCollection values with a singleItemIdentifier set for setFirestoreCollection.');
+      }
     } else {
-      throw new Error('AbstractSingleItemDbxFirebaseDocument only accepts SingleItemFirestoreCollection values with a singleItemIdentifier set for setFirestoreCollection.');
+      return { ...state, firestoreCollection: null };
     }
   });