fix: fixed DbxFirebaseDevelopmentSchedulerService error handling

- fixed issue where error would be cleared every time the scheduled tasks ran regardless of whether or not an error occurred
dereekb · Oct 9, 2022 · 3763fdf · 3763fdf
1 parent 5ceec11
commit 3763fdf
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/packages/dbx-firebase/src/lib/development/development.scheduler.service.ts b/packages/dbx-firebase/src/lib/development/development.scheduler.service.ts
@@ -59,14 +59,19 @@ export class DbxFirebaseDevelopmentSchedulerService implements Initialized {
                 exhaustMap(() => {
                   console.log('Running scheduled tasks in order... ', executionOrder);
 
-                  return PromiseUtility.runTasksForValues(executionOrder, (taskName) => this.runScheduledFunction(taskName), { sequential: true, retriesAllowed: 0, retryWait: 0 }).catch((e) => {
-                    console.log('Failed running scheduled task: ', e);
-                    this._error.next(true);
-                  });
+                  return PromiseUtility.runTasksForValues(executionOrder, (taskName) => this.runScheduledFunction(taskName), { sequential: true, retriesAllowed: 0, retryWait: 0 })
+                    .then(() => true)
+                    .catch((e) => {
+                      console.log('Failed running scheduled task: ', e);
+                      this._error.next(true);
+                      return false;
+                    });
                 }),
-                tap(() => {
-                  console.log('Successfully finished running all scheduled tasks.');
-                  this._error.next(false);
+                tap((success) => {
+                  if (success) {
+                    console.log('Successfully finished running all scheduled tasks.');
+                    this._error.next(false);
+                  }
                 })
               );
             })