fix: fixed enableMultiTabIndexedDbPersistence usage

- fixed issue where trying to use both enableMultiTabIndexedDbPersistence and enableMultiTabIndexedDbPersistence at the same time - enableMultiTabIndexedDbPersistence is now the default, with enableIndexedDbPersistence being used if enableMultiTabIndexedDbPersistence is false
dereekb · Jan 24, 2023 · 2c41552 · 2c41552
1 parent 0db398a
commit 2c41552
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/packages/dbx-firebase/src/lib/firebase/firebase.module.ts b/packages/dbx-firebase/src/lib/firebase/firebase.module.ts
@@ -30,12 +30,10 @@ import { DbxFirebaseAppCheckHttpInterceptor } from '../auth/appcheck/appcheck.in
         connectFirestoreEmulator(firestore, emulators.firestore.host, emulators.firestore.port, {});
       }
 
-      if (firebaseOptions.enableIndexedDbPersistence !== false) {
-        enableIndexedDbPersistence(firestore);
-      }
-
       if (firebaseOptions.enableMultiTabIndexedDbPersistence !== false) {
         enableMultiTabIndexedDbPersistence(firestore);
+      } else if (firebaseOptions.enableIndexedDbPersistence !== false) {
+        enableIndexedDbPersistence(firestore);
       }
 
       return firestore;

diff --git a/packages/dbx-firebase/src/lib/firebase/options.ts b/packages/dbx-firebase/src/lib/firebase/options.ts
@@ -17,15 +17,15 @@ export interface DbxFirebaseOptions extends FirebaseOptions, Pick<DbxFirebaseLog
    */
   functionsRegionOrCustomDomain?: string | undefined;
   /**
-   * Whether or not to call enableIndexedDbPersistence() for firestore at setup time.
+   * Whether or not to call enableMultiTabIndexedDbPersistence() for firestore at setup time.
    *
    * True by default.
    */
-  enableIndexedDbPersistence?: boolean;
+  enableMultiTabIndexedDbPersistence?: boolean;
   /**
-   * Whether or not to call enableMultiTabIndexedDbPersistence() for firestore at setup time.
+   * Whether or not to call enableIndexedDbPersistence() for firestore at setup time.
    *
-   * True by default.
+   * True by default if enableMultiTabIndexedDbPersistence is false.
    */
-  enableMultiTabIndexedDbPersistence?: boolean;
+  enableIndexedDbPersistence?: boolean;
 }