Skip to content

fix: set default request timeout to 120 seconds #3253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxsxu
Copy link

@maxsxu maxsxu commented Apr 8, 2025

Motivation

Fixes #3207

Modifications

  • Change default request timeout to 120s from 5s. Since 5s is too short for most of requests, especially for large clusters in production environment.

And according to kubectl docs, the default kubectl request timeout is 0 which means don't timeout requests. Maybe we should do so too for k9s, but let's see.

Signed-off-by: Max Xu <xuhuan@live.cn>
@derailed
Copy link
Owner

@maxsxu Thank you for this update! The current default timeout is 10s.
I am hesitating making it any bigger, since you can easily override it with a cli arg.
What do you think?

@derailed derailed added the question Further information is requested label Apr 13, 2025
@maxsxu
Copy link
Author

maxsxu commented Apr 14, 2025

@maxsxu Thank you for this update! The current default timeout is 10s. I am hesitating making it any bigger, since you can easily override it with a cli arg. What do you think?

@derailed Thanks for reply!

And yes we can override via cli arg, but if this is something users' frequent use case, then we can make it a common option.

So wondering what's the backwards if making the default timeout bigger? If that won't break us, then I suggest making it bigger.

@robert-openai
Copy link

robert-openai commented Apr 14, 2025

@derailed Could you at least make it something you can set in config.yaml? I didn't see anything mentioned in the documentation about it. The K8s clusters I deal with regularly are far too big to reliably reply within the default request timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frequent timeout when listing some resources but kubectl works
3 participants