feat: pass context and token flags to kubectl exec commands #3169
+67
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When executing shell in a container, only the kubeconfig flag was being passed to kubectl exec commands. This change ensures that context and bearer token flags are also passed when available, maintaining consistency with the initial k9s configuration parameters.
derailed
requested changes
Mar 7, 2025
| @@ -337,7 +337,8 @@ func sshIn(a *App, fqn, co string) error { | |||
| return fmt.Errorf("os detect failed: %w", err) | |||
| } | |||
|
|
|||
| args := buildShellArgs("exec", fqn, co, a.Conn().Config().Flags().KubeConfig) | |||
| flags := a.Conn().Config().Flags() | |||
| args := buildShellArgs("exec", fqn, co, flags.KubeConfig, flags.Context, flags.BearerToken) | |||
There was a problem hiding this comment.
@fabianonunes I think it will be best to just pass in the k8s flags at the call site and let buildShellArgs figure out what it need to extract out.
derailed
added
enhancement
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing k9s with
--kubeconfig,--context, and--tokenparameters, only the--kubeconfigflag was being passed tokubectl execwhen running a shell in a container. This inconsistency could lead to authentication issues or accessing the wrong cluster when using shell functionality.This PR ensures that all relevant authentication flags (
--kubeconfig,--context, and--token) are consistently passed to kubectl commands when executing a shell in a container.This PR:
buildShellArgsfunction to accept context and token parameters