feat: adding taints list #3115
Open
feat: adding taints list #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding TAINTS-LIST column in Wide mode to show current taints present on node.
derailed
requested changes
Mar 12, 2025
| @@ -132,6 +134,21 @@ func (n Node) defaultRow(nwm *NodeWithMetrics, r *model1.Row) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func formatTaints(taints []v1.Taint) string { | |||
| if len(taints) == 0 { | |||
There was a problem hiding this comment.
I don't think this check is necessary.
| @@ -25,8 +25,27 @@ func TestNodeRender(t *testing.T) { | |||
| assert.Nil(t, err) | |||
|
|
|||
| assert.Equal(t, "minikube", r.ID) | |||
| e := model1.Fields{"minikube", "Ready", "master", "amd64", "0", "v1.15.2", "Buildroot 2018.05.3", "4.15.0", "192.168.64.107", "<none>", "0", "10", "20", "0", "0", "4000", "7874"} | |||
| assert.Equal(t, e, r.Fields[:17]) | |||
| e := model1.Fields{ | |||
There was a problem hiding this comment.
Might be a good idea to test the taint list is ok. Or at the very least test formatTaints.
derailed
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding TAINTS-LIST column in wide mode to show current taints present on a node.
I tried new custom views feature and found it is quite difficult to add a column with list of taints present on node.
But the same time it is quite easy to achieve with this simple PR.