Skip to content

fix: "Toggle Decode" only implemented for Describe #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nagytiboradam
Copy link
Contributor

Secret decode toggling is only implemented for describe action, for yaml action it's not, so this change would limit it to the former.
Would it make sense to implement decode toggling for yaml too?

@placintaalexandru
Copy link
Contributor

Hello @nagytiboradam

I wrote that IsDecodable part. It was meant to allow the user to view, if possible, everything that could be base64 decoded.

To answer your questions:

  1. I do not see any purpose with && v.title == describeAction. In the future we may have other base64 encoded resources that users may want to see the values for and the command may not be describe, but something else.
  2. I do not think it makes sense to implement decode toggling for yaml (and here I'll be very specific with my use case): I want to see the yaml to copy it to a file and apply it in another namespace, so for secrets I want to see the yaml with base64 values

@derailed derailed added the question Further information is requested label Jan 12, 2025
@derailed
Copy link
Owner

@placintaalexandru Thanks for weighting in. I agree. @nagytiboradam did you have other scenarios in mind that would warrant this feature?

@derailed derailed added the enhancement New feature or request label Feb 16, 2025
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants