chore: update dependencies #3539

dbowling · 2022-07-11T21:18:04Z

Updates project dependencies to current versions when possible.

The following dependencies are one or more major versions behind and have not been upgraded to latest, but should be safe for minor and patch updates.

chalk: 4.x (latest is 5.0.1)
Version 5 is breaking due to ESM only https://github.com/chalk/chalk/releases/tag/v5.0.0
execa: 5.x (latest is 6.1.0)
Version 6 is breaking due to ESM only https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
globby: 11.x (latest is 13.1.2)
Version 12 is breaking due to ESM only https://github.com/sindresorhus/globby/releases/tag/v12.0.0
html-entities: 1.x (latest is 2.3.3)
Version 2 is breaking due to ESM only https://github.com/mdevils/html-entities/releases/tag/v2.0.0
markdown-table: 2.x (latest is 3.0.2)
Version 3 is breaking due to ESM only https://github.com/wooorm/markdown-table/releases/tag/3.0.0
mocha: 9.x (latest is 10.0.0)
Version 10 drops IE 11 and Node 12 support https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#1000--2022-05-01
sinon: 11.x (latest is 14.0.0)
Version 12 is breaking due to ESM only https://github.com/sinonjs/sinon/blob/main/CHANGES.md#1200
Version 10 is breaking due to IE 11 not supporting template literals https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals#browser_compatibility

Seleniumn is pinned due to a bug, but should be easily updated in the future.

selenium-webdriver is pinned to 4.3.0 because 4.3.1 introduces a breaking change from 4.3.0->4.3.1
selenium-webdriver/chrome#setDefaultService() https://github.com/SeleniumHQ/selenium/pull/10796/files#diff-6c87d95a2288e92e15a6bb17710c763c01c2290e679beb26220858f3218b6a62L260

Also, it appears the selenium webdriver browser message "Chrome is being controlled by automated software" changes the window height when it appears between running the two axe runs. To fix deepEqual, we assign the height to be identical: axeRunPartialResult.testEnvironment = axeRunResult.testEnvironment;

ESBuild is upgraded to 0.14.7 (0.14.50 is latest) due to flaky windows tests. This is the version that passed CI and was reasonably up-to-date.

replaces: PR #3535

# Conflicts: # package-lock.json # package.json

depenencies with a .x cannot be upgraded further

package.json

requested by Michael

Flakey test locally; checking CI

Requires “internet explorer”

deepEqual() assert failed because selenium now places a banner that throws off window height

…core into chore/update-dependencies

v11 introduces ESM

confirmed v10 sinon does not support IE11 for CI

straker

LGTM. @WilcoFiers should also approve since I helped a bit.

WilcoFiers

Couple minor points

.husky/pre-commit

WilcoFiers · 2022-07-15T12:12:33Z

doc/aria-supported.md

+| aria-attribute | axe-core support |
+| -------------- | ---------------- |


This seems odd. Should we turn off this part of the task? An empty table doesn't seem useful to me.

I couldn't find any other docs page that had an empty table, so this does stand out. Since it is generated dynamically, would disabling the rule have unexpected consequences in the future?

My thoughts now are to not disable the task, but instead alter aria-supported.js to output an empty string if this might bite us later. If not, disabling the task or culling the code would certainly be easiest.

Something needs to be done there. It's definitely outdated. Perhaps we should change that page to ARIA 1.3. I'll open a ticket.

Ok, I'll let you open a ticket and will mark this as resolved as-is.

New issue for this is #3590.

test/integration/full/run-partial/after-method.js

WilcoFiers · 2022-07-19T20:23:28Z

package.json

    "minami": "^1.2.3",
-    "mocha": "^9.2.0",
-    "node-notifier": "^8.0.1",
+    "mocha": "9.x",


Why not Mocha 10?

Because version 10 drops IE 11 and Node 12 support.

https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#1000--2022-05-01

I spoke with @straker yesterday. Since we need the IE 11 support, we won't upgrade to Mocha 10 and will leave this comment as unresolved in the PR.

.husky/pre-commit

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

# Conflicts: # package-lock.json

dbowling · 2022-07-25T19:09:53Z

This PR is ready for security review, even though it has pending changes--those will be left open, see above.

Resolved

dbowling added 10 commits July 8, 2022 12:35

update esbuild to support m1

5ded8e8

update webdriverjs

bff9fe9

update babel

cd5ea5c

update act rules

6fb29f9

update aria practices

43e414e

aria-query bump

a478d08

update babel

a0ef56a

husky 3.x

80b685e

# Conflicts: # package-lock.json # package.json

chore: update dependencies

741d174

depenencies with a .x cannot be upgraded further

Pin execa due to ESM

0d51118

dbowling marked this pull request as ready for review July 11, 2022 22:03

dbowling requested a review from a team as a code owner July 11, 2022 22:03

dbowling requested a review from michael-siek July 11, 2022 22:04

michael-siek previously requested changes Jul 11, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

dbowling added 4 commits July 12, 2022 08:32

bump selenium-webdriver

f087bf2

requested by Michael

partial fix for selenium-webdriver 3.4.0

7759993

Flakey test locally; checking CI

fix selenium browser name

33afb49

Requires “internet explorer”

Fix deepEqual assert

761120d

deepEqual() assert failed because selenium now places a banner that throws off window height

dbowling requested a review from straker July 13, 2022 18:57

dbowling added 6 commits July 13, 2022 13:10

Fix deepEqual assert

cd64570

deepEqual() assert failed because selenium now places a banner that throws off window height

Merge branch 'chore/update-dependencies' of github.com:dequelabs/axe-…

c78d480

…core into chore/update-dependencies

fix deepEqual due to webdriver issue

7f3d5a9

update globby

a875b83

update sinon to 10.x

41a3b1e

v11 introduces ESM

roll back sinon to v9.x

c0aaa20

confirmed v10 sinon does not support IE11 for CI

dbowling self-assigned this Jul 13, 2022

straker reviewed Jul 14, 2022

View reviewed changes

WilcoFiers requested changes Jul 15, 2022

View reviewed changes

dbowling added 2 commits July 19, 2022 00:11

break up &&

7401913

linting

209d637

WilcoFiers previously requested changes Jul 19, 2022

View reviewed changes

straker previously requested changes Jul 20, 2022

View reviewed changes

.husky/pre-commit Outdated Show resolved Hide resolved

dbowling and others added 4 commits July 21, 2022 09:02

require dev dependencies to be installed

e8372ce

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

Merge branch 'develop' into chore/update-dependencies

e25d695

# Conflicts: # package-lock.json

regenerate package-lock after integration

7c37fee

jsdoc patch update

7a2c4d2

dbowling force-pushed the chore/update-dependencies branch from 6da694d to 7a2c4d2 Compare July 22, 2022 16:17

dbowling added 12 commits July 22, 2022 14:51

patch core-js

183101e

downgrade esbuild

ce9fe59

update esbuild to 0.13.1

a0a8a33

upgrade esbuild to 0.13.2

b509e98

esbuild 0.13.15

a48ae9e

update esbuild to 0.14.0

4d55a63

update esbuild to 0.14.1

9e6f4a4

update esbuild to 0.14.2

ff17a6f

update esbuild to 0.14.3

8869e25

update esbuild to 0.14.5

c67e48d

update esbuild to 0.14.6

ff628a0

update esbuild to 0.14.7

464953c

dbowling requested a review from michael-siek July 25, 2022 19:10

straker approved these changes Jul 25, 2022

View reviewed changes

straker merged commit d01532c into develop Jul 25, 2022

straker deleted the chore/update-dependencies branch July 25, 2022 20:07

dbowling mentioned this pull request Jul 26, 2022

pre-commit hook is not executable #3566

Closed

dbowling mentioned this pull request Aug 9, 2022

Doc aria-supported outputs empty table #3590

Open

straker mentioned this pull request Oct 10, 2022

chore: update dependencies #3712

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update dependencies #3539

chore: update dependencies #3539

dbowling commented Jul 11, 2022 •

edited

Loading

straker left a comment

WilcoFiers left a comment

WilcoFiers Jul 15, 2022

dbowling Jul 19, 2022 •

edited

Loading

WilcoFiers Jul 19, 2022

dbowling Jul 19, 2022

dbowling Aug 9, 2022

WilcoFiers Jul 19, 2022

dbowling Jul 19, 2022

dbowling Jul 21, 2022

dbowling commented Jul 25, 2022

		\| aria-attribute \| axe-core support \|
		\| -------------- \| ---------------- \|

chore: update dependencies #3539

chore: update dependencies #3539

Conversation

dbowling commented Jul 11, 2022 • edited Loading

straker left a comment

Choose a reason for hiding this comment

WilcoFiers left a comment

Choose a reason for hiding this comment

WilcoFiers Jul 15, 2022

Choose a reason for hiding this comment

dbowling Jul 19, 2022 • edited Loading

Choose a reason for hiding this comment

WilcoFiers Jul 19, 2022

Choose a reason for hiding this comment

dbowling Jul 19, 2022

Choose a reason for hiding this comment

dbowling Aug 9, 2022

Choose a reason for hiding this comment

WilcoFiers Jul 19, 2022

Choose a reason for hiding this comment

dbowling Jul 19, 2022

Choose a reason for hiding this comment

dbowling Jul 21, 2022

Choose a reason for hiding this comment

dbowling commented Jul 25, 2022

dbowling commented Jul 11, 2022 •

edited

Loading

dbowling Jul 19, 2022 •

edited

Loading