Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update babel dependencies #1443

Merged
merged 2 commits into from
Mar 19, 2019
Merged

chore: update babel dependencies #1443

merged 2 commits into from
Mar 19, 2019

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Mar 18, 2019 •
edited by WilcoFiers
Loading

Update babel deps

Closes issue:

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@jeeyyy jeeyyy requested a review from a team as a code owner March 18, 2019 11:38
@jeeyyy jeeyyy changed the title chore: update babel dependencies [WIP] chore: update babel dependencies Mar 18, 2019
@stephenmathieson
Copy link
Member

@JKODU can you please explain "why" this change is necessary?

@jeeyyy
Copy link
Contributor Author

jeeyyy commented Mar 18, 2019

@stephenmathieson as discussed during the call, babel is deprecating all of their ~6.x plugins and presets in a push to move to ~7.x

@jeeyyy jeeyyy changed the title [WIP] chore: update babel dependencies chore: update babel dependencies Mar 18, 2019
@jeeyyy jeeyyy merged commit aace2f3 into develop Mar 19, 2019
@jeeyyy jeeyyy deleted the update-babel-deps branch March 19, 2019 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeeyyy @stephenmathieson @WilcoFiers