Skip to content

Commit

Permalink
feat(aria-roles): deprecate the ARIA directory role (#3952)
Browse files Browse the repository at this point in the history
* feat(aria-roles): deprecate the ARIA directory role

* update tests
  • Loading branch information
straker authored Mar 22, 2023
1 parent 8714d6b commit 893fdd0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions lib/standards/aria-roles.js
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ const ariaRoles = {
},
directory: {
type: 'structure',
deprecated: true,
allowedAttrs: ['aria-expanded'],
superclassRole: ['list'],
// Note: spec difference
Expand Down
2 changes: 1 addition & 1 deletion test/integration/rules/aria-roles/aria-roles.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
<div role="contentinfo" id="pass11">ok</div>
<div role="definition" id="pass12">ok</div>
<div role="dialog" id="pass13">ok</div>
<div role="directory" id="pass14">ok</div>
<div role="document" id="pass15">ok</div>
<div role="feed" id="pass16">ok</div>
<div role="form" id="pass17">ok</div>
Expand Down Expand Up @@ -135,6 +134,7 @@
<!-- deprecated roles-->
<div role="doc-biblioentry" id="fail14">fail</div>
<div role="doc-endnote" id="fail15">fail</div>
<div role="directory" id="fail16">ok</div>
</div>

<!-- inapplicable -->
Expand Down
4 changes: 2 additions & 2 deletions test/integration/rules/aria-roles/aria-roles.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
["#fail12"],
["#fail13"],
["#fail14"],
["#fail15"]
["#fail15"],
["#fail16"]
],
"passes": [
["#pass1"],
Expand All @@ -32,7 +33,6 @@
["#pass11"],
["#pass12"],
["#pass13"],
["#pass14"],
["#pass15"],
["#pass16"],
["#pass17"],
Expand Down

0 comments on commit 893fdd0

Please sign in to comment.