fix(color-contrast): fix color-contrast check when running in an exte…

…nsion (#3838)
dequelabs · Dec 22, 2022 · 31a3e01 · 31a3e01
1 parent d5f6ca9
commit 31a3e01
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/lib/commons/color/get-background-color.js b/lib/commons/color/get-background-color.js
@@ -141,25 +141,24 @@ function fullyEncompasses(node, rects) {
   rects = Array.isArray(rects) ? rects : [rects];
 
   const nodeRect = node.getBoundingClientRect();
+  let { right, bottom } = nodeRect;
   const style = window.getComputedStyle(node);
   const overflow = style.getPropertyValue('overflow');
 
   if (
     ['scroll', 'auto'].includes(overflow) ||
     node instanceof window.HTMLHtmlElement
   ) {
-    nodeRect.width = node.scrollWidth;
-    nodeRect.height = node.scrollHeight;
-    nodeRect.right = nodeRect.left + nodeRect.width;
-    nodeRect.bottom = nodeRect.top + nodeRect.height;
+    right = nodeRect.left + node.scrollWidth;
+    bottom = nodeRect.top + node.scrollHeight;
   }
 
   return rects.every(rect => {
     return (
       rect.top >= nodeRect.top &&
-      rect.bottom <= nodeRect.bottom &&
+      rect.bottom <= bottom &&
       rect.left >= nodeRect.left &&
-      rect.right <= nodeRect.right
+      rect.right <= right
     );
   });
 }