-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Planning: Advanced crate handling #105
Comments
I believe #26 should also be considered alongside those issues. Like #95 and #12, it's something that users may wish to opt in for a particular project.
My interpretation is that this one should also enable the analysis of any repository within premises and with the right credentials, and not just public repos. |
You're right, I didn't notice this when browsing the issue list. Dutifully added. Ah, hence the |
Ok so after giving this a bit of thought, I would propose this first idea, let me know what you think. We could add
All these changes would of course require documentation, not just for us internally, but also on the deployed page. I could imagine either a Documentation section on the page, or even better, a nice dialogue for generating the link on the landing page, combining all the features mentioned above in a sort of lookup mask you can fill to scan a repository. Apart from the Lockfile, nothing of the things above targets crates.io, but it should still be available as dialogue (maybe selectable via a panel or something). This is just my first idea on how to solve this. Let me know what you think. The only thing that would be missing here is handling credentials to private repositories of any sort, not really sure how to handle that since every platform has a homegrown solution to authenticating these requests. |
Self-hosted environments will (I think) usually be limited to a known set of repositories¹. Through a local configuration file, these repositories could be given a short alias, and so not require specifying a full URL. This would also enable specifying credentials or other means of granting access to the repository. ¹ Granted, there's usually a repository central system, such as Phabricator's Diffusion. But right now I don't picture an integration at this level in deps.rs. |
Ah, that's an interesting take, bearing another question: Should the deployed version on |
It seems to me that a local configuration based deployment could work for deps.rs as well as self-hosted deployments. Aliases we already have: github, gitlab, bitbucket. They could be described with the same configuration as other internal aliases; just without authentication needed. I think it would be useful to support the API key auth systems used by self hosted versions of github, gitlab, bitbucket as well as HTTP basic auth to support a vast array of setups. I do not thing deps.rs should try itself to support reaching into internal systems. |
Looking through the issue list, it appears that we have a number of different feature requests in the backlog that affect the URL handling and/or the way the application interacts with repositories/selects crates. These issues are:
I think that these issues should be solved separately. But we should probably think about how general solutions could look like (and what of these should be implemented in our public instance or if some of these things require a private instance).
All these issues will probably alter the routing scheme so it would make sense to think about things like these in a central issue so we don't end up with several different (or conflicting) solutions.
The text was updated successfully, but these errors were encountered: