Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] auto carousel with Swiper && 지난 기수 후기 컴포넌트 #256

Merged
merged 7 commits into from
Sep 16, 2023

Conversation

kimyouknow
Copy link
Member

작업 내용

  • Swiper.js를 활용한 공통 컴포넌트
    • 기본 carousel
    • auto infinite carousel
    • 사용법은 storybook 참고!
  • 지난 기수 후기 컴포넌트

스크린샷

123.mov

사용 방법

Swiper 컴포넌트는 라이브러리의 의존성을 줄이기 위해 라이브러리를 바로 쓰기보다 component로 한 번 래핑했어요! 네이밍이 같아서 헷갈릴 수 있는데 참고해주세요

다른 컴포넌트에서 쓸 일은 많이 없고 가로 무한 캐러셀에서 사용하는데 자세한 사용법은 storybook 참고해주세요.

레퍼런스

@vercel
Copy link

vercel bot commented Sep 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www-depromeet-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2023 6:13am

@github-actions
Copy link

github-actions bot commented Sep 10, 2023

Bundle Sizes

Compared against d4bc7f9

Route Size (gzipped) Diff
/ 72.18 KB -10.08 KB
/404 71.89 KB -4.91 KB
/_app 114.71 KB -16.21 KB
/about 72.2 KB -12.73 KB
/project 72.2 KB -22.66 KB
/recruit 72.2 KB -13.04 KB
/contact no change removed
/project/[projectTitle] no change removed
/recruit/[position] no change removed
Dynamic import Size (gzipped) Diff
../components/project-detail/OtherProjectSection.tsx -> ../project/ProjectItem/ProjectItem no change removed

Copy link
Member

@sumi-0011 sumi-0011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 윤호님 코드 참고해 개발해보겠습니다!

@github-actions github-actions bot added the style change style or request it label Sep 16, 2023
@kimyouknow kimyouknow merged commit 332b088 into develop Sep 16, 2023
10 checks passed
@kimyouknow kimyouknow deleted the feat/auto-carousel branch September 16, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style change style or request it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants