fix: 템플릿 질문 리스트 질문 추가 과정에서 나오는 "질문 수정을 취소하시겠어요" 모달을 이전 화면 과정에서 이탈시 나오게 제공#798
Hidden character warning
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| })); | ||
| } | ||
| }, [editingQuestions, isAddMode]); | ||
| }, [isAddMode, handleCancel, setModalDataState]); |
There was a problem hiding this comment.
여기 의존성 배열에 setter 함수를 넣은 이유는 무엇인지 궁금해요!
There was a problem hiding this comment.
지금 exhaustive-deps 규칙이 꺼져있지는 않은거 같은데, 표기가 안되어서 습관처럼 setter 함수도 넣어준거 같습니다.
크게 의도한 바는 아니긴 합니다..!
Claude code랑 검토해본 결과, setModalDataState은 Primitive atom의 setter라서 참조가 안정적이라고 합니다.
그래서 넣어도 문제가 없고, 빼도 문제가 없다고 하네요!!
-> 빼도록 하겠습니다!
| @@ -105,17 +105,34 @@ export default function QuestionEditSection({ onClose }: QuestionEditSectionProp | |||
| if (questions.length >= 10) return; | |||
There was a problem hiding this comment.
큰건아니지만 10 매직넘버 상수화 해도 좋을 듯합니다요!
There was a problem hiding this comment.
사용된 곳이 꽤 많아서... 꽤 큰 듯합니다..!!ㅋㅎㅋㅎ
피드백 감사합니다 :)
prgmr99
force-pushed
the
795-템플릿-질문-리스트-질문-추가-과정에서-나오는-질문-수정을-취소하시겠어요-모달을-이전-화면-과정에서-이탈시-나오게-제공
branch
from
142c7a5 to
b448e2d
Compare
prgmr99
deleted the
795-템플릿-질문-리스트-질문-추가-과정에서-나오는-질문-수정을-취소하시겠어요-모달을-이전-화면-과정에서-이탈시-나오게-제공
branch
3 participants
🏄🏼♂️ Summary (요약)
🫨 Describe your Change (변경사항)
🧐 Issue number and link (참고)
📚 Reference (참조)
2026-02-01.3.42.47.mov