Skip to content

Comments

feat: 질문 추가 기능 작업#582

Merged
prgmr99 merged 7 commits intodevelopfrom
580-feat-질문-추가-작업
Oct 18, 2025

Hidden character warning

The head ref may contain hidden characters: "580-feat-\uc9c8\ubb38-\ucd94\uac00-\uc791\uc5c5"
Merged

feat: 질문 추가 기능 작업#582
prgmr99 merged 7 commits intodevelopfrom
580-feat-질문-추가-작업

Conversation

@prgmr99
Copy link
Member

@prgmr99 prgmr99 commented Oct 17, 2025

질문 추가 기능


🏄🏼‍♂️‍ Summary (요약)

  • 회고 생성 중, 질문을 직접 커스텀하고, 추가하는 기능을 적용했습니다.

🫨 Describe your Change (변경사항)

  • DesktopModal의 닫힘버튼 비활성화 옵션 추가(disableClose)
  • 질문 추가 중 이탈 시, 경고 모달 적용

🧐 Issue number and link (참고)

📚 Reference (참조)

2025-10-18.8.37.51.mov

@prgmr99 prgmr99 self-assigned this Oct 17, 2025
@prgmr99 prgmr99 added the 🚀 feature New feature or request label Oct 17, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 17, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • Not Rabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 580-feat-질문-추가-작업

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@prgmr99 prgmr99 changed the base branch from main to develop October 17, 2025 23:45
@prgmr99 prgmr99 force-pushed the 580-feat-질문-추가-작업 branch from 290f915 to 595578a Compare October 17, 2025 23:52
@prgmr99 prgmr99 marked this pull request as ready for review October 17, 2025 23:52
@prgmr99 prgmr99 force-pushed the 580-feat-질문-추가-작업 branch from 595578a to a8494a8 Compare October 17, 2025 23:57
Comment on lines 20 to 61
<Typography variant="title16Bold">메인 질문</Typography>
{isDeleteMode ? (
<div
css={css`
display: flex;
align-items: center;
gap: 0.8rem;
`}
>
<Typography
variant="body14SemiBold"
color="gray500"
css={css`
cursor: pointer;
`}
onClick={handleDeleteModeToggle}
>
취소
</Typography>
<Typography
variant="body14SemiBold"
color="gray900"
css={css`
cursor: pointer;
`}
onClick={handleDeleteModeToggle}
>
완료
</Typography>
</div>
) : (
<Typography
variant="body14SemiBold"
color="gray500"
css={css`
cursor: pointer;
`}
onClick={handleDeleteModeToggle}
>
삭제
</Typography>
)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타이포그래피 형태의 클릭 이벤트를 같은 버튼 느낌이어서 아래와 같이 해당 헤더 안에서 사용하는 버튼용 컴포넌트를 하나 만들어놓으면 스타일을 추후에 한 부분에서만 수정하면 좋지 않을까 싶은데 어떻게 생각하시는지 궁금해요!

const ActionButton = ({
  label,
  color,
  onClick,
}: {
  label: string;
  color: string;
  onClick: () => void;
}) => (
  <Typography
    variant="body14SemiBold"
    color={color}
    css={css`
      cursor: pointer;
    `}
    onClick={onClick}
  >
    {label}
  </Typography>
);
Suggested change
<Typography variant="title16Bold">메인 질문</Typography>
{isDeleteMode ? (
<div
css={css`
display: flex;
align-items: center;
gap: 0.8rem;
`}
>
<Typography
variant="body14SemiBold"
color="gray500"
css={css`
cursor: pointer;
`}
onClick={handleDeleteModeToggle}
>
취소
</Typography>
<Typography
variant="body14SemiBold"
color="gray900"
css={css`
cursor: pointer;
`}
onClick={handleDeleteModeToggle}
>
완료
</Typography>
</div>
) : (
<Typography
variant="body14SemiBold"
color="gray500"
css={css`
cursor: pointer;
`}
onClick={handleDeleteModeToggle}
>
삭제
</Typography>
)}
{isDeleteMode ? (
<>
<ActionButton label="취소" color="gray500" onClick={handleDeleteModeToggle} />
<ActionButton label="완료" color="gray900" onClick={handleDeleteModeToggle} />
</>
) : (
<ActionButton label="삭제" color="gray500" onClick={handleDeleteModeToggle} />
)}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉..!! 저도 이게 있으면 참 좋겠다고 생각했는데,,,
마음이 급해서 실천하지는 못했습니다..

말씀대로 만들어서 반영해볼게요..!! 👍

Copy link
Member Author

@prgmr99 prgmr99 Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klmhyeonwoo @JaeIn1 @supersett

이렇게 구현해보았습니다..!!
(혹시 몰라서 다른 분들께도 공유드립니다..!!)

ActionButton은 텍스트 기반의 클릭 가능한 액션 버튼을 위한 공통 컴포넌트입니다.
일반적인 Button 컴포넌트와 달리, 배경이나 테두리 없이 텍스트만으로 구성된 가벼운 액션 버튼입니다.

위치는 apps/web/src/component/common/ActionButton/index.tsx입니다!

type ActionButtonProps = {
  label: string;
  variant: keyof typeof DESIGN_TOKEN_TEXT;
  color: ComponentProps<typeof Typography>["color"];
  onClick: () => void;
};

export default function ActionButton({ label, variant, color, onClick }: ActionButtonProps) {
  return (
    <Typography
      variant={variant}
      color={color}
      css={css`
        cursor: pointer;
      `}
      onClick={onClick}
    >
      {label}
    </Typography>
  );
}
2025-10-18.9.34.26.mov

실제로는 커서 포인터가 적용이 되는데, 녹화할 때는 적용이 안 되는 것 같아요!

Copy link
Member

@klmhyeonwoo klmhyeonwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다요!! 👍 짱짱!!

@prgmr99 prgmr99 force-pushed the 580-feat-질문-추가-작업 branch from 8f782c6 to f4de8af Compare October 18, 2025 12:37
@prgmr99 prgmr99 merged commit 0cd28ad into develop Oct 18, 2025
2 checks passed
@prgmr99 prgmr99 deleted the 580-feat-질문-추가-작업 branch October 18, 2025 12:42
@klmhyeonwoo
Copy link
Member

어라 그러고보니 저 프로필 사진.. 달토끼.. ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ

@prgmr99
Copy link
Member Author

prgmr99 commented Oct 20, 2025

어라 그러고보니 저 프로필 사진.. 달토끼.. ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ

예전에 하고 저장한건데, 잘쓰고 있슴다ㅎ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚀 feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: 질문 추가 작업

2 participants