feat: 회고 작성 UI 및 API 연동 by JaeIn1 · Pull Request #579 · depromeet/layer

JaeIn1 · 2025-10-16T08:53:06Z

회고 작성 UI 및 API 연동

🏄🏼‍♂️‍ Summary (요약)

회고 작성하기 페이지의 UI 및 API 연동을 완료했습니다.
회고 분석 페이지와 유사한 레이아웃으로, 일부 코드를 참고했습니다.

🫨 Describe your Change (변경사항)

경로: /retrospect/write
쿼리 파라미터: spaceId, retrospectId, title, introduction
- 모바일과 달리 URL 쿼리로 데이터 전달
DesktopModal에 header에 옵셔널 속성을 추가했습니다.

🧐 전달사항

DesktopModal의 콘텐츠 영역에 부모 div에 패딩이 적용되어 있는데,
회고 작성 완료 화면에서는 패딩이 다르게 적용되어 있습니다. 이 부분을 콘텐츠 내부에서 처리하는 것이 좋을지 함께 논의하고 싶습니다.

📚 Reference (참조)

2025-10-17.8.56.11.mov

coderabbitai · 2025-10-16T08:53:17Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

Not Rabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 553-회고-작성-ui-구현

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai · 2025-10-16T08:53:18Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

Not Rabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 553-회고-작성-ui-구현

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

prgmr99

고생하셨습니다~~!! LGTM👍

코드가 깔끔해서 이해하기 쉬웠슴다 :)

prgmr99 · 2025-10-17T03:02:05Z

apps/web/src/component/write/QuestionItem.tsx

+          font-size: ${isDesktop ? "1.6rem" : "1.4rem"};
+          font-weight: ${isDesktop ? "600" : "500"};
+          line-height: ${isDesktop && "140%"};


contents에 Typography를 적용하기에는 쉽지 않을까요?

엇 제가 의도를 정확히 이해하지 못한 것 같습니다..

하단에 contents 부분에 반영이 되는 스타일링 같아서요..!
아래와 같이 적용해도 되지 않을까해서 남겨봤습니다!

<Typography variant={isDesktop ? ~~ : ~~} >{contents}</Typography>

승준님이 추천해주신 부분 말고도
${isDekstop ? css``" : "css``} 형태로도 모바일과 데스크탑 스타일의 구분이 하나의 분기로 명확하게 나눠질 수 있을 것 같아요!

prgmr99 · 2025-10-17T03:05:44Z

apps/web/src/app/desktop/component/retrospectWrite/index.tsx

  introduction: string;
 };

+export const AdvanceQuestionsNum = 2;


혹시 요거는 무슨 변수일까요??!

진행사항, 목표 진행률에 합계를 나타내는 변수입니다!!

klmhyeonwoo · 2025-10-18T03:42:50Z

apps/web/src/types/modal.ts

    type?: "confirm" | "alert";
    buttonText?: string[];
    autoClose?: boolean;
+    enableHeader?: boolean;


이게 그 데스크탑 모달의 헤더를 지우는 옵셔널로 추가된 부분 맞죠?!

넵넵 맞습니다!!

klmhyeonwoo

고생하셨습니다! 작업량이 많네요 ;)

…-회고-작성-ui-구현

JaeIn1 added 5 commits October 8, 2025 22:30

feat: 회고 작성 Prepare 페이지 UI 구현

f39abd2

feat: 회고 작성 UI 퍼블리싱 완료

b82f740

fix: develop 머지 충돌 해결(RetrospectCard)

240b4d1

fix: 누락된 key속성 추가

4257174

feat: 회고 작성 dialog 헤더 크기 조정 추가

14e24fa

JaeIn1 self-assigned this Oct 16, 2025

JaeIn1 added the 🚀 feature New feature or request label Oct 16, 2025

github-actions bot requested review from klmhyeonwoo, prgmr99 and supersett October 16, 2025 08:53

prgmr99 approved these changes Oct 17, 2025

View reviewed changes

JaeIn1 added 3 commits October 17, 2025 20:25

feat: 회고 작성 api 연동 완료

7cb3f04

remove: 불필요한 import 제거

4534e3b

fix: 회고 나가기 누락된 기능 수정

a22efa5

JaeIn1 changed the title ~~feat: 회고 작성 UI 구현~~ feat: 회고 작성 UI 및 API 연동 Oct 17, 2025

fix: 진행사항, 목표진행 컴포넌트 높이 차이 수정

4e54547

klmhyeonwoo reviewed Oct 18, 2025

View reviewed changes

klmhyeonwoo approved these changes Oct 18, 2025

View reviewed changes

JaeIn1 added 4 commits October 18, 2025 21:19

feat: refactor: postRetrospect onSuccess 로직 분리

44db9ce

refactor: QuestionItem 폰트 스타일 수정

c8e8697

fix: develop 머지 충돌 해결

ea407fe

Merge branch 'develop' of https://github.com/depromeet/layer into 553…

17dfa42

…-회고-작성-ui-구현

JaeIn1 merged commit ecafcf1 into develop Oct 18, 2025
2 checks passed

Comments

Conversation

JaeIn1 commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

회고 작성 UI 및 API 연동

🏄🏼‍♂️‍ Summary (요약)

🫨 Describe your Change (변경사항)

🧐 전달사항

📚 Reference (참조)

Uh oh!

coderabbitai bot commented Oct 16, 2025

Review skipped

Uh oh!

coderabbitai bot commented Oct 16, 2025

Review skipped

Uh oh!

prgmr99 left a comment

Choose a reason for hiding this comment

Uh oh!

prgmr99 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

JaeIn1 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

prgmr99 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

klmhyeonwoo Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prgmr99 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

JaeIn1 Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

klmhyeonwoo Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

JaeIn1 Oct 18, 2025

Choose a reason for hiding this comment

Uh oh!

klmhyeonwoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JaeIn1 commented Oct 16, 2025 •

edited

Loading

klmhyeonwoo Oct 18, 2025 •

edited

Loading

JaeIn1 Oct 17, 2025 •

edited

Loading