feat: 온보딩을 구현합니다 #444
Merged
feat: 온보딩을 구현합니다 #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wokbjso
requested review from
hjy0951,
Jungjjeong and
summermong
as code owners
Jungjjeong
approved these changes
Oct 8, 2024
| } | ||
|
|
||
| export function Steps({ current }: StepsProps) { | ||
| const highlightText = (text: string, highlightTexts: string[]) => { |
There was a problem hiding this comment.
함수이므로 getHighlightedText가 더 명시적이지 않을까요?
추가로 정규식 파싱에는 특수문자가 들어갔을 경우 종종 예상치 못한 에러가 발생합니다.
이 함수가 공통 함수로 분리될 가능성이 있으면 props로 받은 문자열에서 특수문자를 모두 치환해주는 작업이 추가로 필요할 것 같아요!
하지만 요 함수는 온보딩에서만 사용하는 함수이니 패스 💯
| { | ||
| total: '수영 친구를 팔로우하고 응원을 주고받아요', | ||
| highlight: ['수영 친구를 팔로우'], | ||
| }, |
There was a problem hiding this comment.
introduce와 이미지 데이터를 하나의 배열로 만들어도 될 것 같아요.
각각 따로 상수를 생성하신 이유가 있을까요?
There was a problem hiding this comment.
음 제가 놓친 부분인거 같아요!!
말씀하신대로 이미지도 같이 관리하는게 유지보수에도 더 좋을 것 같아요 ㅎㅎ
king2dwellsang
added
Approved 🆗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 어떤 문제가 발생했나요?
🎉 어떻게 해결했나요?
📷 이미지 첨부 (Option)
default.mp4
default.mp4