chore: 이미지 깨짐 현상 수정을 위한 시도 #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wokbjso
requested review from
hjy0951,
Jungjjeong and
summermong
as code owners
king2dwellsang
added
Approved 🆗
Jungjjeong
approved these changes
Sep 13, 2024
| @@ -37,7 +37,7 @@ export function PhotoSection({ | |||
| try { | |||
| if (e.target.files) { | |||
| const targetFile = e.target.files[0]; | |||
| const resizedImage = await resizeFile(targetFile, 600, 600, 100); | |||
| const resizedImage = await resizeFile(targetFile, 800, 1000, 100); | |||
There was a problem hiding this comment.
800 1000이 어떤 값인가요?
width / height인가유?
There was a problem hiding this comment.
최대 width와 최대 height를 지정하는 속성이에요!!
확인해보니 기록 상세에서 최대로 나올 수 있는 이미지 크기가 560 * 672 인데, 이걸 고려하여 좀 더 넉넉히 최대 크기를 지정해주었습니다 :)
There was a problem hiding this comment.
오호 맞아요. 보통 사용자에게 안깨지게 보이게 하기 위해서 저희 사내에서도 최소 1.5배의 사진 크기가 권장되고 있어요.
굿굿입니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 어떤 문제가 발생했나요?
🎉 어떻게 해결했나요?
📷 이미지 첨부 (Option)