Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 기록 수정 플로우 변경 #414

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Conversation

wokbjso
Copy link
Member

@wokbjso wokbjso commented Sep 8, 2024

🤔 어떤 문제가 발생했나요?

🎉 어떻게 해결했나요?

  • 기록 수정 시에는 새로운 성공 페이지로 이동하는 것이 아닌, toast를 띄운 후 -> 기록 상세 페이지로 이동되는 플로우로 수정하였습니다.

📷 이미지 첨부 (Option)

image
default.mp4

⚠️ 유의할 점! (Option)

  • NA

@king2dwellsang king2dwellsang added the chore # Chores label Sep 8, 2024
@king2dwellsang king2dwellsang added the Review Plz🙏 # Review is not yet complete label Sep 8, 2024
@wokbjso wokbjso changed the title chore: 기록 수정 플로우 수정 chore: 기록 수정 플로우 변경 Sep 8, 2024
Copy link
Member

@Jungjjeong Jungjjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

router.replace(
`/record/success?editMode=true&memoryId=${Number(memoryId)}`,
);
router.replace(`/record-detail/${Number(memoryId)}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 수정된 기록 데이터 잘 반영 되나요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네네 반영 잘 됩니다 :)

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Sep 8, 2024
@wokbjso wokbjso merged commit 45c012a into main Sep 8, 2024
11 of 13 checks passed
@wokbjso wokbjso deleted the chore/record-edit-flow branch September 8, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved 🆗 # Review is completed chore # Chores
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants