Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 수영 거리가 없는 상태에서 레인 수정시, 0m 혹은 NaN이 뜨는 버그 수정 #406

Merged
merged 2 commits into from
Sep 8, 2024
Merged

fix: 수영 거리가 없는 상태에서 레인 수정시, 0m 혹은 NaN이 뜨는 버그 수정 #406

merged 2 commits into from
Sep 8, 2024

Conversation

wokbjso
Copy link
Member

@wokbjso wokbjso commented Sep 8, 2024 •
edited
Loading

🤔 어떤 문제가 발생했나요?

  • 수영 거리가 없는 상태에서 레인 수정시, 수영 거리가 바뀌는 버그가 있습니다.

🎉 어떻게 해결했나요?

  • totalDistance가 정의되어 있을 시에만, 레인 수정이 반영되도록 수정하였습니다.

📷 이미지 첨부 (Option)

  • before
default.mp4
  • after
default.mp4

⚠️ 유의할 점! (Option)

  • NA

@king2dwellsang king2dwellsang added Review Plz🙏 # Review is not yet complete fix # Fix bug labels Sep 8, 2024
Jungjjeong
Jungjjeong approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@Jungjjeong Jungjjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏻

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Sep 8, 2024
@Jungjjeong
Copy link
Member

asis영상이 업로드되다가 중단된 것 같아요!

@wokbjso wokbjso merged commit ab8fad0 into main Sep 8, 2024
4 of 6 checks passed
@wokbjso wokbjso deleted the fix/total-distance-nam branch September 8, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jungjjeong Jungjjeong Jungjjeong approved these changes

@hjy0951 hjy0951 Awaiting requested review from hjy0951 hjy0951 is a code owner

@summermong summermong Awaiting requested review from summermong summermong is a code owner

Assignees

@wokbjso wokbjso

Labels
Approved 🆗 # Review is completed fix # Fix bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wokbjso @Jungjjeong @king2dwellsang