Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design: 알림 스켈레톤 디자인 수정 #404

Merged
merged 4 commits into from
Sep 8, 2024

Conversation

wokbjso
Copy link
Member

@wokbjso wokbjso commented Sep 8, 2024

🤔 어떤 문제가 발생했나요?

  • 알림 스켈레톤 디자인이 부자연스러워 보였습니다.

🎉 어떻게 해결했나요?

  • 화면 크기에 따라 알맞게 width가 변화하도록 % 단위를 사용하였습니다.

  • 화면 초기에 렌더링 되는 스켈레톤 item 개수를 조금 늘려주었습니다.

📷 이미지 첨부 (Option)

default.mp4

⚠️ 유의할 점! (Option)

  • NA

@king2dwellsang king2dwellsang added design # Modifying style code Review Plz🙏 # Review is not yet complete labels Sep 8, 2024
Copy link
Member

@Jungjjeong Jungjjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Sep 8, 2024
@wokbjso wokbjso merged commit c53e062 into main Sep 8, 2024
1 of 2 checks passed
@wokbjso wokbjso deleted the design/notification-skeleton branch September 8, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved 🆗 # Review is completed design # Modifying style code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants