[PHPStanRules] Remove NoMaskWithoutSprintfRule, might be useful to us…

…e mask sometimes
deprecated-packages · Feb 20, 2022 · 8615230 · 8615230
1 parent 9f70dfd
commit 8615230
Show file tree

Hide file tree

Showing 10 changed files with 1 addition and 309 deletions.
diff --git a/packages/phpstan-rules/config/static-rules.neon b/packages/phpstan-rules/config/static-rules.neon
@@ -120,10 +120,6 @@ services:
         class: Symplify\PHPStanRules\Rules\NoSuffixValueObjectClassRule
         tags: [phpstan.rules.rule]
 
-    -
-        class: Symplify\PHPStanRules\Rules\NoMaskWithoutSprintfRule
-        tags: [phpstan.rules.rule]
-
     -
         class: Symplify\PHPStanRules\Rules\RequireThisOnParentMethodCallRule
         tags: [phpstan.rules.rule]

diff --git a/packages/phpstan-rules/docs/rules_overview.md b/packages/phpstan-rules/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 132 Rules Overview
+# 130 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -1435,69 +1435,6 @@ final class SomeRector implements RectorInterface
 
 <br>
 
-## ForbiddenPrivateMethodByTypeRule
-
-Private method in is not allowed here - it should only delegate to others. Decouple the private method to a new service class
-
-:wrench: **configure it!**
-
-- class: [`Symplify\PHPStanRules\Rules\ForbiddenPrivateMethodByTypeRule`](../src/Rules/ForbiddenPrivateMethodByTypeRule.php)
-
-```yaml
-services:
-    -
-        class: Symplify\PHPStanRules\Rules\ForbiddenPrivateMethodByTypeRule
-        tags: [phpstan.rules.rule]
-        arguments:
-            forbiddenTypes:
-                - Command
-```
-
-↓
-
-```php
-class SomeCommand extends Command
-{
-    public function run()
-    {
-        $this->somePrivateMethod();
-    }
-
-    private function somePrivateMethod()
-    {
-        // ...
-    }
-}
-```
-
-:x:
-
-<br>
-
-```php
-class SomeCommand extends Command
-{
-    /**
-     * @var ExternalService
-     */
-    private $externalService;
-
-    public function __construct(ExternalService $externalService)
-    {
-        $this->externalService = $externalService;
-    }
-
-    public function run()
-    {
-        $this->externalService->someMethod();
-    }
-}
-```
-
-:+1:
-
-<br>
-
 ## ForbiddenProtectedPropertyRule
 
 Property with protected modifier is not allowed. Use interface contract method instead
@@ -2694,28 +2631,6 @@ final class HelpfulName
 
 <br>
 
-## NoMaskWithoutSprintfRule
-
-Missing `sprintf()` function for a mask
-
-- class: [`Symplify\PHPStanRules\Rules\NoMaskWithoutSprintfRule`](../src/Rules/NoMaskWithoutSprintfRule.php)
-
-```php
-return 'Hey %s';
-```
-
-:x:
-
-<br>
-
-```php
-return sprintf('Hey %s', 'Matthias');
-```
-
-:+1:
-
-<br>
-
 ## NoMethodTagInClassDocblockRule
 
 Do not use `@method` tag in class docblock

diff --git a/packages/phpstan-rules/src/Rules/NoMaskWithoutSprintfRule.php b/packages/phpstan-rules/src/Rules/NoMaskWithoutSprintfRule.php
diff --git a/packages/phpstan-rules/tests/Rules/NoMaskWithoutSprintfRule/Fixture/NoSprintf.php b/packages/phpstan-rules/tests/Rules/NoMaskWithoutSprintfRule/Fixture/NoSprintf.php
diff --git a/packages/phpstan-rules/tests/Rules/NoMaskWithoutSprintfRule/Fixture/SkipHerenowdoc.php b/packages/phpstan-rules/tests/Rules/NoMaskWithoutSprintfRule/Fixture/SkipHerenowdoc.php
diff --git a/packages/phpstan-rules/tests/Rules/NoMaskWithoutSprintfRule/Fixture/SkipIdentical.php b/packages/phpstan-rules/tests/Rules/NoMaskWithoutSprintfRule/Fixture/SkipIdentical.php
diff --git a/packages/phpstan-rules/tests/Rules/NoMaskWithoutSprintfRule/Fixture/SkipOnConstant.php b/packages/phpstan-rules/tests/Rules/NoMaskWithoutSprintfRule/Fixture/SkipOnConstant.php
diff --git a/packages/phpstan-rules/tests/Rules/NoMaskWithoutSprintfRule/Fixture/SkipWithSprintf.php b/packages/phpstan-rules/tests/Rules/NoMaskWithoutSprintfRule/Fixture/SkipWithSprintf.php
diff --git a/packages/phpstan-rules/tests/Rules/NoMaskWithoutSprintfRule/NoMaskWithoutSprintfRuleTest.php b/packages/phpstan-rules/tests/Rules/NoMaskWithoutSprintfRule/NoMaskWithoutSprintfRuleTest.php
diff --git a/packages/phpstan-rules/tests/Rules/NoMaskWithoutSprintfRule/config/configured_rule.neon b/packages/phpstan-rules/tests/Rules/NoMaskWithoutSprintfRule/config/configured_rule.neon