Skip to content

Conversation

@olvlvl
Copy link
Collaborator

@olvlvl olvlvl commented Feb 16, 2017

Hi,

I redesigned my bootstrap theme, improving search suggestions, sidebar overflow, legibility, and I also replaced the bootstrap v3 styles with a selection of v4 (I removed the big bootstrap file).

Biggest changes:

  • Removed all panels and most tables. The class view is the most impacted. I replaced the table columns by a flat view with: name, type, attributes. Now it displays fine on smaller screens.
  • Search suggestions are displayed full screen, under the search input.
  • If the menu inside the sidebar overflows, it is shown entirely when the mouse hovers, making it more readable. I removed the splitter since it's of no use anymore.
  • Replaced some PNG files with glyphs, added a SVG icon for the link.
  • New behavior for the search button
  • The theme is now responsive, you can check your documentation from your phone.

You can see it in action over here: https://olvlvl.com/apigen/class-ApiGen.Parser.Reflection.ReflectionElement.html

Feedback appreciated <3

@jankal
Copy link

jankal commented Mar 12, 2017

This may be shipped with the next version of apigen.
@olvlvl You may merge it yourself.

@jankal
Copy link

jankal commented Mar 12, 2017

@olvlvl I'm concerned of how the user is able to open up the source. I tried in your demo but I wasn't able to open up the source of a specific method.

@olvlvl
Copy link
Collaborator Author

olvlvl commented Mar 13, 2017

I have to look into this because I'm generating my docs without sources.

@TomasVotruba
Copy link
Member

TomasVotruba commented Mar 31, 2017

Hi @olvlvl ,

thank you for great work!

We are merging themes to main ApiGen\ApiGen repository, already did for DefaultTheme, so it's easier to develop.

Could you send PR there after you finish it here? I'll take care about the changes in v5, don't worry about them.

@olvlvl olvlvl merged commit 4257ef3 into deprecated-packages:master Apr 2, 2017
@TomasVotruba
Copy link
Member

Can I add this?

@olvlvl
Copy link
Collaborator Author

olvlvl commented Apr 8, 2017

Hi Tomas, give me a sec, I'll do it.

@olvlvl
Copy link
Collaborator Author

olvlvl commented Apr 8, 2017

Here: ApiGen/ApiGen#840

@TomasVotruba
Copy link
Member

Awesome job. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants