Skip to content
This repository was archived by the owner on Jan 12, 2021. It is now read-only.
This repository was archived by the owner on Jan 12, 2021. It is now read-only.

I want to be able to include package_data without an extension #14

Description

@jochenparm

I'm having an issue with including a couple of files that I explicitly mention in my pyproject.toml but that don't end up in the package_data list of the converted setup.py

After a lot of trial and error, I started looking into how dephell actually identifies the files to be included. It appears that you're making the assumption that files without an extension are to be ignored.

Would you consider adapting this behavior? As far as I know, it's not bad practice to allow for files without an extension to be packaged up.

# skip dirs, python files and files without extension

Activity

  1. jochenparm commented on Oct 21, 2020

    @jochenparm
    Author

    Can someone give me some feedback? It's easy enough to create a PR that fixes this, but I suppose that there might be a reason that it was implemented like this initially?

  2. orsinium commented on Oct 21, 2020

    @orsinium
    Member

    Sure, feel free to contribute.

  3. jochenparm commented on Oct 22, 2020

    @jochenparm
    Author

    @orsinium
    Can you have a look at the PR and let me know if it needs additional work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions