Move to Node10, automate build & installation, add SARIF reports #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostVoskuil
commented
Dec 11, 2021
•
JoostVoskuil
commented
- Automated the build process:
- Create a public Azure DevOps project
- Authorize Azure DevOps project to use this git repository
- Update azure-pipelines.yml and set variable 'shareWith'. This is the Azure DevOps organisation to run your tests installations from
- To make this work, the extension version is bumped to version 6.1
- No need anymore to update both extension version and task version manually for patch versions
- Removed manual build steps
- Remove unused dependencies (package.json)
- Removed unused typescript files
- Bumped dependency versions of package.json
- Update to node10 handler (Switch to Node10 Execution Handler #91)
- tsconfig.json target from es6 to es2020
- Made chagnes to dependency-check-build-task.ts to support this (removed undefined '?' for variablen)
- Migrated file upload old vso console.out to tasklib upload method
- Dependency-Check option format also supports SARIF reports. This change will provide the option to tell dependency-check to generate the report also in SARIF.
- If we want nice reports in Azure DevOps with the SARIF SAST Scans Tab extension, the SARIF file must be uploaded to the 'CodeAnalysisLogs' artifact hence it is uploaded twice
JoostVoskuil
changed the title
ejohn20
reviewed
Dec 12, 2021
| @@ -0,0 +1,128 @@ | |||
| name: '6.1$(rev:.r)' | |||
There was a problem hiding this comment.
I'm not opposed to switching away from the classic pipelines, however I might need to work through this configuration with you all to make sure I understand how the dev -> prod workflow will work.
There was a problem hiding this comment.
It is quite easy. If you want we can have a zoom call and discuss this ;)
There was a problem hiding this comment.
@JoostVoskuil That would be helpful. I'm going to be tied up this week for the most part at a conference, would you be available the next week (12/20) to review?
There was a problem hiding this comment.
Hi @ejohn20 I have send you an email ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.