Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling ScatteredSetup Rubocop rule #9980

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

GarryHurleyJr
Copy link
Contributor

@GarryHurleyJr GarryHurleyJr commented Jun 12, 2024

https://www.rubydoc.info/gems/rubocop-rspec/1.10.0/RuboCop/Cop/RSpec/ScatteredSetup

What are you trying to accomplish?

The ScatteredSetup Rubocop rule has been disabled for some tests. This PR enables the rule for all of the ecosystem

Anything you want to highlight for special attention from reviewers?

Autocorrect may create some funky syntax. Please be alert for such changes.

How will you know you've accomplished your goal?

The setup for the tests should be much cleaner.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@GarryHurleyJr GarryHurleyJr requested review from a team as code owners June 12, 2024 12:53
@github-actions github-actions bot added L: php:composer Issues and code for Composer L: ruby:bundler RubyGems via bundler L: elixir:hex Elixir packages via hex L: java:gradle Maven packages via Gradle L: go:modules Golang modules L: elm Elm packages L: docker Docker containers L: rust:cargo Rust crates via cargo L: dotnet:nuget NuGet packages via nuget or dotnet L: javascript L: python labels Jun 12, 2024
@GarryHurleyJr GarryHurleyJr force-pushed the GarryHurleyJr/enableRSpecScatteredSetup branch from f430358 to effea2a Compare June 13, 2024 12:50
@JamieMagee JamieMagee force-pushed the GarryHurleyJr/enableRSpecScatteredSetup branch from effea2a to a702c15 Compare June 13, 2024 16:36
@GarryHurleyJr GarryHurleyJr force-pushed the GarryHurleyJr/enableRSpecScatteredSetup branch from a702c15 to 30a39d5 Compare June 13, 2024 16:54
@GarryHurleyJr GarryHurleyJr merged commit 6620402 into main Jun 13, 2024
121 checks passed
@GarryHurleyJr GarryHurleyJr deleted the GarryHurleyJr/enableRSpecScatteredSetup branch June 13, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet L: elixir:hex Elixir packages via hex L: elm Elm packages L: go:modules Golang modules L: java:gradle Maven packages via Gradle L: javascript L: php:composer Issues and code for Composer L: python L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants