Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable All RSpec empty line cops #9791

Merged
merged 6 commits into from
May 23, 2024
Merged

Enable All RSpec empty line cops #9791

merged 6 commits into from
May 23, 2024

Conversation

robaiken
Copy link
Contributor

@robaiken robaiken commented May 21, 2024 •
edited
Loading

@robaiken robaiken requested review from a team as code owners May 21, 2024 13:22
@github-actions github-actions bot added L: php:composer Issues and code for Composer L: ruby:bundler RubyGems via bundler L: elixir:hex Elixir packages via hex L: java:gradle Maven packages via Gradle L: go:modules Golang modules L: github:actions GitHub Actions L: elm Elm packages L: git:submodules Git submodules L: terraform Terraform packages L: docker Docker containers L: rust:cargo Rust crates via cargo L: dotnet:nuget NuGet packages via nuget or dotnet L: java:maven Maven packages via Maven L: dart:pub Dart packages via pub L: javascript L: python L: devcontainers labels May 21, 2024
jurre
jurre approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@jurre jurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would merge this quickly or you will have all the merge conflicts

@robaiken robaiken self-assigned this May 22, 2024
@robaiken robaiken linked an issue May 23, 2024 that may be closed by this pull request
Enable New RuboCop Cops #9573
Closed
@robaiken robaiken merged commit 13bf811 into main May 23, 2024
121 checks passed
@robaiken robaiken deleted the robaiken/enable-Mega-EmptyLine branch May 23, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieMagee JamieMagee JamieMagee approved these changes

@jurre jurre jurre approved these changes

Assignees

@robaiken robaiken

Labels
L: dart:pub Dart packages via pub L: devcontainers L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet L: elixir:hex Elixir packages via hex L: elm Elm packages L: git:submodules Git submodules L: github:actions GitHub Actions L: go:modules Golang modules L: java:gradle Maven packages via Gradle L: java:maven Maven packages via Maven L: javascript L: php:composer Issues and code for Composer L: python L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo L: terraform Terraform packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable New RuboCop Cops
3 participants
@robaiken @jurre @JamieMagee