Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable RSpec/NamedSubject #9748

Merged
merged 37 commits into from
May 29, 2024
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
3d80d6d
Enable RSpec/NamedSubject bundler
robaiken May 16, 2024
6d02ab4
Enable RSpec/NamedSubject cargo
robaiken May 16, 2024
c0009a2
Enable RSpec/NamedSubject common
robaiken May 16, 2024
168c7d6
Enable RSpec/NamedSubject devcontainers
robaiken May 16, 2024
10300ab
Enable RSpec/NamedSubject docker
robaiken May 16, 2024
089b90a
Fixing tests for common
robaiken May 16, 2024
6557843
Enable RSpec/NamedSubject elm
robaiken May 16, 2024
cd854be
Enable RSpec/NamedSubject github_actions
robaiken May 16, 2024
c910f4f
Enable RSpec/NamedSubject go_modules
robaiken May 16, 2024
fb16448
Enable RSpec/NamedSubject gradle
robaiken May 16, 2024
d12aedc
Fixing linting issues with go_modules
robaiken May 16, 2024
f07f3e4
Enable RSpec/NamedSubject hex
robaiken May 16, 2024
c4492d1
Enable RSpec/NamedSubject maven
robaiken May 16, 2024
6d424bd
Enable RSpec/NamedSubject npm_and_yarn
robaiken May 16, 2024
7091386
Enable RSpec/NamedSubject nuget
robaiken May 17, 2024
81f9a55
Enable RSpec/NamedSubject pub
robaiken May 17, 2024
be70628
Enable RSpec/NamedSubject python
robaiken May 17, 2024
1422dd8
Enable RSpec/NamedSubject swift
robaiken May 17, 2024
5445ea9
Enable RSpec/NamedSubject terraform
robaiken May 17, 2024
1956837
Enable RSpec/NamedSubject updater
robaiken May 17, 2024
3f4a091
make subject python test
robaiken May 17, 2024
358e88e
fixing pub test
robaiken May 17, 2024
43e4d9d
fixing terraform and python test
robaiken May 17, 2024
29cd779
Merge branch 'main' into robaiken/enable-RSpec-NameSubject
robaiken May 17, 2024
9bbbae7
Reenable RSpec/NamedSubject
robaiken May 17, 2024
2695769
Enable RSpec/NamedSubject composer
robaiken May 17, 2024
641a196
:gemspec -> :dependency
robaiken May 17, 2024
85d5e61
:gemspec -> :dependency
robaiken May 17, 2024
36c8055
Merge branch 'main' into robaiken/enable-RSpec-NameSubject
robaiken May 23, 2024
1cf3e32
fixing new NameSubject
robaiken May 23, 2024
88b54a0
use correct subject
robaiken May 23, 2024
a5e850d
Merge branch 'main' into robaiken/enable-RSpec-NameSubject
robaiken May 23, 2024
b896233
Merge branch 'main' into robaiken/enable-RSpec-NameSubject
robaiken May 29, 2024
0f40dae
fixing lint
robaiken May 29, 2024
d63200a
Merge remote-tracking branch 'origin/robaiken/enable-RSpec-NameSubjec…
robaiken May 29, 2024
51585ea
remove NameSubjects on git commit checker spec
robaiken May 29, 2024
1805928
Merge branch 'main' into robaiken/enable-RSpec-NameSubject
robaiken May 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing new NameSubject
  • Loading branch information
robaiken committed May 23, 2024
commit 1cf3e322882570634ceb38d04ef708352110e257
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@
end

describe "#latest_version" do
subject { finder.latest_version }
subject(:latest_version) { finder.latest_version }
before do
stub_request(:get, sparse_registry_url).to_return(status: 200, body: sparse_registry_response)
end
Expand Down Expand Up @@ -341,7 +341,7 @@
context "with raise_on_ignored" do
let(:raise_on_ignored) { true }
it "raises an error" do
expect { subject }.to raise_error(Dependabot::AllVersionsIgnored)
expect { latest_version }.to raise_error(Dependabot::AllVersionsIgnored)
end
end
end
Expand Down Expand Up @@ -375,13 +375,13 @@
context "when all versions are being ignored" do
let(:ignored_versions) { [">= 0"] }
it "returns nil" do
expect(subject).to be_nil
expect(latest_version).to be_nil
end

context "with raise_on_ignored" do
let(:raise_on_ignored) { true }
it "raises an error" do
expect { subject }.to raise_error(Dependabot::AllVersionsIgnored)
expect { latest_version }.to raise_error(Dependabot::AllVersionsIgnored)
end
end
end
Expand Down
Loading