#9508: Recreating and Handling "Name contains illegal characters" in package.json #9611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 25, 2024 15:47
…ckage.json error.
…ckage.json error.
npm_and_yarn/helpers/test/yarn/fixtures/updater/illegal_character/package.json
Show resolved
Hide resolved
| @@ -201,6 +201,8 @@ def run_yarn_top_level_updater(top_level_dependency_updates:) | |||
| top_level_dependency_updates | |||
| ] | |||
| ) | |||
| rescue SharedHelpers::HelperSubprocessFailed => e | |||
There was a problem hiding this comment.
is this the only failure when we run yarn update; I assume there are other possible failures too and we should only catch the fileNotParseable specifically.
There was a problem hiding this comment.
Yes ensured, that we are catching only file not parseable error.
[dependabot-core-dev] ~ $ bin/dry-run.rb npm_and_yarn Sotatek-VanPham/colend-utilities
Original repository will generate helpful error saying file contains illegal character.
I have created new repo with same code base by removing the @ character from the name
[dependabot-core-dev] ~ $ bin/dry-run.rb npm_and_yarn thavaahariharangit/colend-utilities
This works with out any error, and generated new package.json with updates
abdulapopoola
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our sentry has raised a new error,
"Name contains illegal characters" error was not handled.
This PR